From: Greg KH <greg@kroah.com>
To: Eirik Aanonsen <EAA@wprmedical.com>
Cc: "kernel@avr32linux.org" <kernel@avr32linux.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] atmel uaba : Adding invert vbus_pin
Date: Mon, 18 Jan 2010 20:49:12 -0800 [thread overview]
Message-ID: <20100119044912.GB10262@kroah.com> (raw)
In-Reply-To: <B5E0EDE940845B429B7ECCE186529F2C0641D181F7@dware2702>
On Mon, Jan 18, 2010 at 08:02:46AM +0100, Eirik Aanonsen wrote:
> >
> > On Mon, Jan 04, 2010 at 02:01:59PM +0100, Eirik Aanonsen wrote:
> > > Adding vbus_pin_inverted so that the usb detect pin can be active
> > high or low.
> > > This because depending on HW implementation it is better to have
> > active low.
> > > Also replaced the pio_get_value(udc->vbus_pin); with a call to
> > vbus_is_present(udc);
> > >
> > > Signed-off-by: Eirik Aanonsen <eaa@wprmedical.com>
> >
> > Please always run your patches through 'scripts/checkpatch.pl' before
> > sending them so that you don't accidentally add coding style errors.
> >
> > thanks,
> >
> > greg k-h
>
> Yes I'm sorry I got that feedback from several others as well.
>
> That is why I resubmitted the patch on 05.Jan. But under the same name, and since then I have not received any feedback on that patch.
>
> ***
> Snip from local:
>
> ./scripts/checkpatch.pl 0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch
> total: 0 errors, 0 warnings, 38 lines checked
>
> 0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch has no obvious style problems and is ready for submission.
> ***
I don't see it in my queue, care to resend?
thanks,
greg k-h
next prev parent reply other threads:[~2010-01-19 4:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 13:01 Eirik Aanonsen
2010-01-04 21:37 ` Sergei Shtylyov
2010-01-04 21:54 ` Ben Nizette
2010-01-15 18:54 ` Greg KH
2010-01-18 7:02 ` Eirik Aanonsen
2010-01-19 4:49 ` Greg KH [this message]
2010-01-19 7:16 ` Eirik Aanonsen
2010-01-27 22:40 ` Greg KH
2010-02-05 8:49 ` Eirik Aanonsen
2010-01-05 8:47 Eirik Aanonsen
2010-01-13 13:20 ` Eirik Aanonsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119044912.GB10262@kroah.com \
--to=greg@kroah.com \
--cc=EAA@wprmedical.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome