mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Hagen Paul Pfeifer <hagen@jauu.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] thinkpad-acpi: fix link error to include sound arch
Date: Tue, 19 Jan 2010 12:51:08 -0200	[thread overview]
Message-ID: <20100119145108.GD2668@khazad-dum.debian.net> (raw)
In-Reply-To: <1263820516-6924-1-git-send-email-hagen@jauu.net>

On Mon, 18 Jan 2010, Hagen Paul Pfeifer wrote:
> Thinkpad ACPI depends on sound for resume/suspend/shutdown
> events. This fix corrects the Kconfig dependency between

Does it?  I'd rather fix the real problem, it shouldn't depend on sound for
resume/suspend/shutdown.  If it does, the fix is to break the dependency.

> in-kernel build and module build. The preprocessor
> directive #ifdef CONFIG_THINKPAD_ACPI_ALSA_SUPPORT
> isn't sufficient to handle this build dependency.

NAK.

Can you describe the problem in more detail?  That will save me precious
time, as I am rather overworked right now...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2010-01-19 14:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 13:15 Hagen Paul Pfeifer
2010-01-19 14:51 ` Henrique de Moraes Holschuh [this message]
2010-01-19 15:07   ` Hagen Paul Pfeifer
2010-02-07 20:05     ` Henrique de Moraes Holschuh
2010-02-20  9:47       ` Hagen Paul Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100119145108.GD2668@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=hagen@jauu.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome