[PATCH] Obsolete config in kernel source (USE_MIXARTLOADER)

[Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

Hi all!

	As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.

	The config Variable USE_MIXARTLOADER has been non-existent for
all git based linux kernels (2.6.12-rc) and seems to be no longer
relevant. It is only referenced at one place in the Code
(sound/pci/mixart/mixart_hwdep.c).

	The attached patch makes the behaviour more obvious as it is
equivalent to the old one when assuming CONFIG_MIXARTLOADER as not
defined.

	Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

	Christoph Egger


[-- Attachment #2: 0001-config-USE_MIXARTLOADER-has-never-existed-in-KConfig.patch --]
[-- Type: text/x-diff, Size: 1133 bytes --]

>From 974a2f370b3401e948821bae47c3e9edb1b21a5e Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Date: Wed, 20 Jan 2010 14:23:47 +0100
Subject: [PATCH] config USE_MIXARTLOADER has never existed in KConfig for 2.6 linux
 kernels so this part of the check always evaluates to true thus
 removing the part of the check.


Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
---
 sound/pci/mixart/mixart_hwdep.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/mixart/mixart_hwdep.c b/sound/pci/mixart/mixart_hwdep.c
index 4cf4cd8..ef39a58 100644
--- a/sound/pci/mixart/mixart_hwdep.c
+++ b/sound/pci/mixart/mixart_hwdep.c
@@ -545,7 +545,7 @@ static int mixart_dsp_load(struct mixart_mgr* mgr, int index, const struct firmw
 
 
 #if defined(CONFIG_FW_LOADER) || defined(CONFIG_FW_LOADER_MODULE)
-#if !defined(CONFIG_USE_MIXARTLOADER) && !defined(CONFIG_SND_MIXART) /* built-in kernel */
+#if !defined(CONFIG_SND_MIXART) /* built-in kernel */
 #define SND_MIXART_FW_LOADER	/* use the standard firmware loader */
 #endif
 #endif
-- 
1.6.3.3