From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Anton Blanchard <anton@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] perf: Fix inconsistency between IP and callchain sampling
Date: Fri, 22 Jan 2010 08:25:47 +0100 [thread overview]
Message-ID: <20100122072547.GB9599@elte.hu> (raw)
In-Reply-To: <20100118104305.GA5256@nowhere>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Concerning interrupts that happen in idle, I think we should filter these if
> exclude_idle = 1. That looks more something a user may want: if we don't
> want to profile idle, neither do we want to encumber with interrupts that
> occur inside. On the opposite, if someone wants a finegrained profile, let's
> get idle and its interrupts.
>
> What do you guys think about that?
Another, related thing i'd _love_ to see implemented is per IRQ level
filtering of both samples and statistics.
This would allow two nice things:
- the reporting of IRQ (and softirq/tasklet) contexts as separate entites by
perf report
- a 'no IRQ related noise' mode for perf task perf stat, like the
user/kernel/hypervisor bits already do, just extended to irqs as well. This
would make 'perf stat --repeat 10 /bin/true' _much_ less noisy, and could
be used even more to assess the performance impact of kernel patches.
Currently IRQs that hit task execution get added to the task's overhead,
which makes the numbers both skewed and noisier.
(The do_IRQ() callbacks are needed because most PMUs cannot stop counters when
we enter/exit IRQ/softirq state, so we have to turn counter off/on on irq
entries.)
Ingo
next prev parent reply other threads:[~2010-01-22 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 5:47 Anton Blanchard
2010-01-18 10:43 ` Frederic Weisbecker
2010-01-22 2:04 ` Anton Blanchard
2010-01-22 7:25 ` Ingo Molnar [this message]
2010-01-21 13:20 ` Frederic Weisbecker
2010-01-29 9:24 ` [tip:perf/core] " tip-bot for Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100122072547.GB9599@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®