From: David Miller <davem@davemloft.net>
To: vapier@gentoo.org
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
fweisbec@gmail.com, mingo@redhat.com, heiko.carstens@de.ibm.com,
lethal@linux-sh.org
Subject: Re: [PATCH v2] ftrace: unify arch_syscall_addr() implementations
Date: Sat, 23 Jan 2010 00:28:03 -0800 (PST) [thread overview]
Message-ID: <20100123.002803.135008520.davem@davemloft.net> (raw)
In-Reply-To: <1264230643-29434-1-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Sat, 23 Jan 2010 02:10:43 -0500
> Most implementations of arch_syscall_addr() are the same, so create a
> default weak version in common code. New arch ports don't have to waste
> time copying & pasting this simple function. The Blackfin version is
> going to be exactly the same for example.
>
> The s390/sparc versions need to be different, so document why.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
You can just have the extern declaration match whatever the
arch needs (long or int) in the generic ftrace.c code and
then unconditionally do the (unsigned long) case.
That way even s390/sparc can use the generic implementation.
next prev parent reply other threads:[~2010-01-23 8:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 13:43 [PATCH] " Mike Frysinger
2010-01-22 14:36 ` Steven Rostedt
2010-01-22 16:37 ` Heiko Carstens
2010-01-22 19:32 ` Mike Frysinger
2010-01-23 1:38 ` David Miller
2010-01-23 1:36 ` David Miller
2010-01-26 3:03 ` Paul Mundt
2010-01-27 4:50 ` Mike Frysinger
2010-01-23 7:10 ` [PATCH v2] " Mike Frysinger
2010-01-23 8:28 ` David Miller [this message]
2010-01-23 19:13 ` Mike Frysinger
2010-01-26 9:40 ` [PATCH v3] " Mike Frysinger
2010-01-26 11:29 ` Heiko Carstens
2010-02-03 22:48 ` Frederic Weisbecker
2010-02-27 12:51 ` [tip:tracing/core] tracing: Unify " tip-bot for Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123.002803.135008520.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome