From: Borislav Petkov <petkovbb@googlemail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@amd64.org>,
tglx@linutronix.de, andreas.herrmann3@amd.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v3 0/5] x86, cacheinfo, amd: L3 Cache Index Disable fixes
Date: Sat, 23 Jan 2010 17:32:23 +0100 [thread overview]
Message-ID: <20100123163223.GA30859@liondog.tnic> (raw)
In-Reply-To: <20100123090135.GB20056@elte.hu>
On Sat, Jan 23, 2010 at 10:01:35AM +0100, Ingo Molnar wrote:
>
> * Borislav Petkov <petkovbb@googlemail.com> wrote:
>
> > On Sat, Jan 23, 2010 at 07:59:53AM +0100, Ingo Molnar wrote:
> > >
> > > * H. Peter Anvin <hpa@zytor.com> wrote:
> > >
> > > > On 01/22/2010 09:40 AM, Borislav Petkov wrote:
> > > > >>>
> > > > >>> Those patches are also good -stable candidates.
> > > > >>
> > > > >> Hmmm... I'm not sure I see a strong justification for a late -rc push
> > > > >> into Linus/stable push for for these... I think you would have to
> > > > >> explicitly make the case if you want them to be considered as such.
> > > > >
> > > > > Well, on the one hand, they fix real bugs in the L3 cache index disable
> > > > > code and since they're bugfixes, they are eligible late -rc candidates.
> > > >
> > > > Bugfixes are *early* -rc candidates. Regression fixes are *late* -rc
> > > > candidates, at least that seems to be the policy Linus currently implements.
> > > > -stable seems to use slightly less strict criteria (the whole point is that
> > > > -final needs to be a stabilization point, backported fixes/drivers can then
> > > > come onto a stable base) which is why you seem some patches which are
> > > > "straight to .1".
> > >
> > > Yes.
> >
> > Ok, thanks for the clarification - my only trouble was that the current
> > code is b0rked as is and those fixes are needed. However, backporting
> > them at a later point seems much more riskfree and I will do so later.
> >
> > Thanks.
>
> Well, if there's a crasher in there, then a minimal fix to address just that
> is preferred for .33 - and that can be tagged for -stable immediately.
As I said earlier, I don't believe we have machines in the wild to
practically support the feature yet so we should be OK without a fix.
Let me verify that next week and get back to you with a minimal fix in
case we have any affected configurations.
Thanks.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2010-01-23 16:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 15:01 Borislav Petkov
2010-01-22 15:01 ` [PATCH 1/5] x86, lib: Add wbinvd smp helpers Borislav Petkov
2010-01-23 0:42 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 2/5] intel-agp: Switch to wbinvd_on_all_cpus Borislav Petkov
2010-01-23 0:42 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 3/5] x86, cacheinfo: Fix disabling of L3 cache indices Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 4/5] x86, cacheinfo: Add cache index disable sysfs attrs only to L3 caches Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 15:01 ` [PATCH 5/5] x86, cacheinfo: Calculate L3 indices Borislav Petkov
2010-01-23 0:43 ` [tip:x86/cpu] " tip-bot for Borislav Petkov
2010-01-22 17:24 ` [PATCH -v3 0/5] x86, cacheinfo, amd: L3 Cache Index Disable fixes H. Peter Anvin
2010-01-22 17:40 ` Borislav Petkov
2010-01-22 17:48 ` H. Peter Anvin
2010-01-23 6:59 ` Ingo Molnar
2010-01-23 8:11 ` Borislav Petkov
2010-01-23 9:01 ` Ingo Molnar
2010-01-23 16:32 ` Borislav Petkov [this message]
2010-01-25 17:06 ` Borislav Petkov
2010-01-27 12:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123163223.GA30859@liondog.tnic \
--to=petkovbb@googlemail.com \
--cc=andreas.herrmann3@amd.com \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®