mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Robert Hancock <hancockrwd@gmail.com>,
	Bastien Nocera <hadess@hadess.net>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	pjones@redhat.com
Subject: Re: [PATCH] Disable i8042 checks on Intel Apple Macs
Date: Mon, 25 Jan 2010 17:34:33 +0100	[thread overview]
Message-ID: <20100125163433.GB31957@suse.cz> (raw)
In-Reply-To: <20100121221701.GA15293@core.coreip.homeip.net>

On Thu, Jan 21, 2010 at 02:17:01PM -0800, Dmitry Torokhov wrote:
> This is from the changelog when this was introduced:
> 
> -------------------------------------------------------------------------
> 2005/02/25 21:21:03+01:00 vojtech
> input: After testing on real world hardware, it's obvious we can't trust
>        ACPIPnP nor PnPBIOS to properly report the existence of a keyboard
>        and mouse port in all cases. Some BIOSes hide the ports if no mouse
>        or keyboard is connected, causing trouble with eg. KVM switches.
> 
>        The i8042 driver now does read-only probing first, which should
>        not cause any problems even if an i8042 controller really is not
>        present.
> 
>        However, on IA64 we still need to trust ACPI, since legacy-free
>        hardware is common there and invalid port accesses cause exceptions.
> 
>  Signed-off-by: Vojtech Pavlik <vojtech@suse.cz>
> 
> >> Input: Add ACPI-based i8042 keyboard and aux controller enumeration;
> > > can be disabled by passing i8042.noacpi as a boot parameter.
> > 
> > On a whim I decided to turn on ACPI, only to discover that my keyboard
> > no longer worked. Passing i8042.noacpi=1 makes it work again.
> > Attached please find boot messages with and without the boot
> > parameter. Inlined below is a diff of the two.
> 
> --------------------------------------------------------------------------
> 
> I'm adding Vojtech in case he manages to recall what other failures he
> has seen.

I don't think I can really recall what other problems we've had back
then, but I do remember it was quite an avalanche of mails that I've
started receiving after enabling the PnPBIOS/ACPIPnP probing and
trusting it fully.

Now, from the hardware point of view it doesn't make much sense for the
BIOS to hide/disable the i8042 controller, as both the keyboard IRQ and
the 0x60-0x6f address space are reserved for it (since the IBM PC/AT
times) and no other hardware can make use of those on an x86
architecture.

And this means that even on a Mac there should be no hardware present on
these addresses if there is no i8042 and Apple is claiming x86
compatibility.

Thus I believe that the right fix here is to figure out why the accesses
to the ports 0x60/0x64 take a long time or forever on a Mac. Is it just
that the kernel is timing out waiting for the i8042? Or is it something
more sinister?

-- 
Vojtech Pavlik
Director SuSE Labs

  parent reply	other threads:[~2010-01-25 16:34 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 18:23 Bastien Nocera
2010-01-20 19:14 ` Justin P. Mattock
2010-01-20 19:37   ` Bastien Nocera
2010-01-20 19:54     ` Justin P. Mattock
2010-01-21  0:41 ` Robert Hancock
2010-01-21  1:31   ` Bastien Nocera
2010-01-21  2:19     ` Robert Hancock
2010-01-21 18:55   ` Dmitry Torokhov
2010-01-21 21:39     ` Robert Hancock
2010-01-21 21:42       ` Bastien Nocera
2010-01-21 21:49       ` Justin P. Mattock
2010-01-22  0:29         ` Robert Hancock
2010-01-22  1:20           ` Justin P. Mattock
2010-01-22  2:09             ` Bastien Nocera
2010-01-22  2:30               ` Robert Hancock
2010-01-22  2:53                 ` Bastien Nocera
2010-01-22  2:31               ` Justin P. Mattock
2010-01-21 22:17       ` Dmitry Torokhov
2010-01-22  0:26         ` Robert Hancock
2010-01-22 17:46           ` H. Peter Anvin
2010-01-22 18:15             ` Bastien Nocera
2010-01-22 22:33             ` Robert Hancock
2010-01-22 22:49               ` H. Peter Anvin
2010-01-25 16:34         ` Vojtech Pavlik [this message]
2010-01-25 21:32           ` H. Peter Anvin
2010-01-25 22:15             ` Dmitry Torokhov
2010-01-25 22:18               ` H. Peter Anvin
2010-01-25 22:30                 ` Dmitry Torokhov
2010-01-25 23:05                   ` H. Peter Anvin
2010-01-25 23:28                     ` Dmitry Torokhov
2010-01-25 23:31                       ` H. Peter Anvin
2010-05-04 17:06               ` Bastien Nocera
2010-05-04 17:23                 ` Dmitry Torokhov
2010-05-04 17:37                   ` Bastien Nocera
2010-05-04 17:36 Bastien Nocera
2010-05-04 17:55 ` Pekka Enberg
2010-05-04 18:02 ` Dmitry Torokhov
2010-05-05  9:18   ` Bastien Nocera
2010-05-05 21:27 ` Kyle McMartin
2010-05-12  0:11 Bastien Nocera
2010-05-12 10:51 ` Felipe Contreras
2010-05-12 11:00   ` Felipe Contreras
2010-05-12 17:51   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100125163433.GB31957@suse.cz \
    --to=vojtech@suse.cz \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=hancockrwd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®