From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: adharmap@codeaurora.org
Cc: linux-arm-kernel@lists.infradead.org, Ingo Molnar <mingo@elte.hu>,
Catalin Marinas <catalin.marinas@arm.com>,
Yinghai Lu <yinghai@kernel.org>, Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Kalle Valo <kalle.valo@iki.fi>, Jean Pihet <jpihet@mvista.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Colin Tuckley <colin.tuckley@arm.com>,
Philby John <pjohn@in.mvista.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Alessandro Rubini <rubini@unipv.it>,
Andrea Gallo <andrea.gallo@stericsson.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Abhijeet Dharmapurikar <adharmap@quicinc.com>
Subject: Re: [RFC PATCH 5/5] gic: initialize interrupts as per argument
Date: Wed, 27 Jan 2010 23:29:55 +0000 [thread overview]
Message-ID: <20100127232955.GG29665@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1264620749-24527-6-git-send-email-adharmap@codeaurora.org>
On Wed, Jan 27, 2010 at 11:32:29AM -0800, adharmap@codeaurora.org wrote:
> From: Abhijeet Dharmapurikar <adharmap@quicinc.com>
>
> Initialize interrupts as per an argument passed instead of initializing
> them as active level low triggered interrupts.
>
> Signed-off-by: Abhijeet Dharmapurikar <adharmap@quicinc.com>
> ---
> Configuring level triggered interrupts as default may not be correct on
> some platforms, this changes the default behaviour of the gic_dist_init
> function and also adds a flag to indicate whether the default should be level
> or edge.
Changing the interrupt type for all interrupts is just wrong. For on-chip
peripherals, you generally want to use level based interrupts as they're
the most efficient and simplest way to signal interrupts.
It should be a per-interrupt thing, and we already have that through
request_irq() etc. Other platforms manage this just fine without having
to have special configuration like this.
next prev parent reply other threads:[~2010-01-27 23:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 19:32 [PATCH 0/5] Arm Gic Changes adharmap
2010-01-27 19:32 ` [PATCH 1/5] gic: prevent gic from crossing NR_IRQ adharmap
2010-01-27 22:43 ` Russell King - ARM Linux
2010-01-28 13:19 ` Catalin Marinas
2010-01-27 19:32 ` [PATCH 2/5] gic: add callback for mask_ack adharmap
2010-01-27 19:32 ` [PATCH 3/5] gic: Add set_type callback adharmap
2010-01-27 23:09 ` Russell King - ARM Linux
2010-01-27 23:18 ` Russell King - ARM Linux
2010-01-28 1:43 ` Abhijeet Dharmapurikar
2010-05-07 10:56 ` Linus Walleij
2010-01-27 19:32 ` [PATCH 4/5] gic: dont disable INT in ack callback adharmap
2010-01-27 19:32 ` [RFC PATCH 5/5] gic: initialize interrupts as per argument adharmap
2010-01-27 23:29 ` Russell King - ARM Linux [this message]
2010-01-28 0:39 ` [PATCH 0/5] Arm Gic Changes Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127232955.GG29665@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=adharmap@codeaurora.org \
--cc=adharmap@quicinc.com \
--cc=andrea.gallo@stericsson.com \
--cc=catalin.marinas@arm.com \
--cc=colin.tuckley@arm.com \
--cc=jpihet@mvista.com \
--cc=kalle.valo@iki.fi \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjohn@in.mvista.com \
--cc=rubini@unipv.it \
--cc=santosh.shilimkar@ti.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tony@atomide.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome