From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jon - <crayzeejon@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Generic PS/2 mouse detected on Fujitsu Lifebook B-Series model laptop instead of LBPS/2 Fujitsu Lifebook TouchScreen
Date: Wed, 27 Jan 2010 16:15:01 -0800 [thread overview]
Message-ID: <20100128001500.GA17185@core.coreip.homeip.net> (raw)
In-Reply-To: <20100127155514.cc743fa4.akpm@linux-foundation.org>
On Wed, Jan 27, 2010 at 03:55:14PM -0800, Andrew Morton wrote:
> (suitable cc's added)
>
> On Mon, 25 Jan 2010 16:12:43 +0000
> jon - <crayzeejon@gmail.com> wrote:
>
> > From: Jon Dodgson <crayzeejon@gmail.com>
> >
> > Fix Detection of Lifebook B-Series Laptop touch screen with DMI
> > product Name string 'Lifebook B Series'
> >
> > Signed-off-by: Jon Dodgson <crayzeejon@gmail.com>
> >
> > ---
> > diff -Nurb linux-2.6.26.2/drivers/input/mouse/lifebook.c
> > linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c
> > --- linux-2.6.26.2/drivers/input/mouse/lifebook.c 2008-08-06
> > 17:19:01.000000000 +0100
> > +++ linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c 2010-01-25
> > 02:56:41.000000000 +0000
> > @@ -51,6 +51,12 @@
> > {
> > .ident = "LifeBook B",
> > .matches = {
> > + DMI_MATCH(DMI_PRODUCT_NAME, "Lifebook B Series"),
> > + },
> > + },
> > + {
> > + .ident = "LifeBook B",
> > + .matches = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B Series"),
> > },
> > },
>
> So the problem is "LifeBook" versus "Lifebook"? These matches are
> case-sensitive?
Yep. And trust to the BIOS writers wil fill this data with as many
permutations as possible.
>
> I don't know what kernel you were patching, but current kernels no
> longer have the ".ident" initialisation in that table. If it _was_
> still there then I'd wonder why you set the ident to "LifeBook B"
> rather than "Lifebook B".
Ident is just for information purposes only (and is was not used by
input that's why it was removed.
>
> Your email client wordwrapped the patch and replaced its tabs with
> spaces.
Yeah ;( Anyway, I ahve it now, thanks.
--
Dmitry
prev parent reply other threads:[~2010-01-28 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 16:12 jon -
2010-01-27 23:55 ` Andrew Morton
2010-01-28 0:15 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128001500.GA17185@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=crayzeejon@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®