From: Paul Mackerras <paulus@samba.org>
To: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] perf: Add util/include/linux/config.h for including generated autoconf.h of kernel
Date: Fri, 29 Jan 2010 09:27:13 +1100 [thread overview]
Message-ID: <20100128222713.GC2585@brick.ozlabs.ibm.com> (raw)
In-Reply-To: <1264688928-12861-1-git-send-email-mitake@dcl.info.waseda.ac.jp>
On Thu, Jan 28, 2010 at 11:28:48PM +0900, Hitoshi Mitake wrote:
> I'd like to add util/include/linux/config.h,
> this header file includes autoconf.h which is generated
> by build phase of kernel.
>
> This makes building of perf depend on building of kernel.
> It's a little dirty. But perf has tight relation
> of its kernel, so I don't think that it is a serious problem.
>
> My original purpose of making this patch is
> knowing size of void *.
> If config.h is available,
> CONFIG_ARCH_PHYS_ADDR_T_64BIT will be provided for source of perf,
> we can know size of void * by this config.
>
> How do you think?
How will this work if I built the kernel in a separate object
directory (e.g., using "make O=../builddir vmlinux")? I think that
trying to include generated files will fail in that case.
In general I think that tying perf to the kernel config is a bad idea.
Paul.
next prev parent reply other threads:[~2010-01-28 22:27 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 13:39 [PATCH 00/12] perf lock: New subcommand "perf lock", for analyzing lock statistics Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 01/12] perf tools: Add __data_loc support Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 02/12] perf: Add util/include/linuxhash.h to include hash.h of kernel Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 03/12] lockdep: Add information of file and line where lock inited to struct lockdep_map Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 04/12] lockdep: Add file and line to initialize sequence of spinlock Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 05/12] lockdep: Add file and line to initialize sequence of rwlock Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 06/12] lockdep: Add file and line to initialize sequence of rwsem Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 07/12] lockdep: Add file and line to initialize sequence of rwsem (x86) Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 08/12] lockdep: Add file and line to initialize sequence of mutex Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 09/12] lockdep: Fix the way to initialize class_mutex for information of file and line Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 10/12] perf lock: Enhance information of lock trace events Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 11/12] perf lock: New subcommand "perf lock", for analyzing lock statistics Hitoshi Mitake
2010-01-28 6:51 ` Hitoshi Mitake
2010-01-28 14:28 ` [PATCH] perf: Add util/include/linux/config.h for including generated autoconf.h of kernel Hitoshi Mitake
2010-01-28 14:44 ` Peter Zijlstra
2010-01-30 11:44 ` Hitoshi Mitake
2010-01-28 22:27 ` Paul Mackerras [this message]
2010-01-30 11:51 ` Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 12/12] Revert "perf record: Intercept all events" Hitoshi Mitake
2010-01-25 2:23 ` Arnaldo Carvalho de Melo
2010-01-25 14:47 ` Hitoshi Mitake
2010-01-25 14:50 ` Peter Zijlstra
2010-01-25 14:57 ` Arnaldo Carvalho de Melo
2010-01-26 7:17 ` Hitoshi Mitake
2010-01-22 16:42 ` [PATCH 00/12] perf lock: New subcommand "perf lock", for analyzing lock statistics Jason Baron
2010-01-22 16:48 ` Peter Zijlstra
2010-01-22 16:52 ` Peter Zijlstra
2010-01-23 6:57 ` Ingo Molnar
2010-01-25 14:15 ` Hitoshi Mitake
2010-01-25 14:48 ` Peter Zijlstra
2010-01-26 7:04 ` Hitoshi Mitake
2010-01-26 4:26 ` Greg KH
2010-01-29 14:34 ` Jens Axboe
2010-01-30 12:00 ` Hitoshi Mitake
2010-01-31 20:44 ` Jens Axboe
2010-01-31 21:07 ` Frederic Weisbecker
2010-01-31 21:11 ` Jens Axboe
2010-02-01 9:15 ` Peter Zijlstra
2010-02-01 9:22 ` Ingo Molnar
2010-02-01 17:58 ` Frederic Weisbecker
2010-02-01 13:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128222713.GC2585@brick.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mitake@dcl.info.waseda.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®