From: Herbert Xu <herbert@gondor.apana.org.au>
To: Matt Mackall <mpm@selenic.com>
Cc: dedekind1@gmail.com, Jeff Angielski <jeff@theptrgroup.com>,
linux-mtd@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: UBIFS assert failed in ubifs_dirty_inode
Date: Fri, 29 Jan 2010 21:48:50 +1300 [thread overview]
Message-ID: <20100129084850.GA23140@gondor.apana.org.au> (raw)
In-Reply-To: <1264484928.3536.1017.camel@calx>
On Mon, Jan 25, 2010 at 11:48:48PM -0600, Matt Mackall wrote:
>
> random: drop weird m_time/a_time manipulation
>
> No other driver does anything remotely like this that I know of except
> for the tty drivers, and I can't see any reason for random/urandom to do
> it. In fact, it's a (trivial, harmless) timing information leak. And
> obviously, it generates power- and flash-cycle wasting I/O, especially
> if combined with something like hwrngd. Also, it breaks ubifs's
> expectations.
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>
Thanks Matt, I'll add this to crypto-2.6 and then stable.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2010-01-29 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B591573.60602@theptrgroup.com>
2010-01-26 4:40 ` Artem Bityutskiy
2010-01-26 5:48 ` Matt Mackall
2010-01-26 10:03 ` Artem Bityutskiy
2010-01-26 10:07 ` Artem Bityutskiy
2010-01-27 1:44 ` Jeff Angielski
2010-01-27 2:13 ` Matt Mackall
2010-01-27 3:07 ` Jeff Angielski
2010-01-27 4:20 ` Artem Bityutskiy
2010-01-27 5:14 ` Matt Mackall
2010-01-29 11:27 ` Herbert Xu
2010-01-29 11:32 ` Artem Bityutskiy
2010-01-29 11:35 ` Herbert Xu
2010-02-02 10:42 ` Artem Bityutskiy
2010-01-29 8:48 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129084850.GA23140@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dedekind1@gmail.com \
--cc=jeff@theptrgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®