mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Mark Lord <kernel@teksavvy.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>
Subject: Re: 2.6.32.5 regression: page allocation failure. order:1,
Date: Fri, 29 Jan 2010 15:46:53 +0000	[thread overview]
Message-ID: <20100129154653.GJ7139@csn.ul.ie> (raw)
In-Reply-To: <4B62E904.9020401@teksavvy.com>

On Fri, Jan 29, 2010 at 08:56:20AM -0500, Mark Lord wrote:
> Mel Gorman wrote:
>> On Thu, Jan 28, 2010 at 09:17:17AM -0500, Mark Lord wrote:
> ..
>>> Rather than wasting time trying to bisect a full major kernel revision,
>>> I think instead I'll just focus on mm/page_alloc.c.
> ..
>> Well, it might not eve be necessary. In the patch I sent you, it pointed
>> the finger at commit 5f8dcc21211a3d4e3a7a5ca366b469fb88117f61 being the
>> problem in that case. I believe your problem is a variation of the
>> slowdown-in-swapping problem except in your case it manifests as
>> GFP_ATOMIC allocations failing.
>>
>> If the fix does not help you, then I'll take a fresh look at the other
>> commits with your particular problem in mind.
> ..
>
> Last night, I installed 2.6.32.7, plus the patch you sent.
> So far, no allocation faults.
>

Nice one.

> I'll leave it running for another day or so, and then perhaps revert
> the one patch to see which of the two things (new kernel, or patch)
> is responsible for the difference.
>

Thanks, I'd appreciate it. While I'm reasonably confident the problem is
with MIGRATE_RESERVE not being free as intended and that the patch fixes
it, I'd like more proof.

> The changelog for 2.6.32.7 included something to fix default rsize/wsize
> values on NFS.  Dunno if this might have had an effect or not,
> but when it was failing.. NFS (order 1) was the most frequent case.
>

I consider it unlikely that a change in NFS is responsible. The network
MTU would remain the same and it's a bigger factor in the size of
allocations made. I think it's just a co-incidence that NFS reported the
most failures simply because it was responsible for the bulk of network
traffic.

Hugh, can I get a signed-off-by on that patch please? I can improve the
changelog if you like and send it to Andrew for merging if you like.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

  reply	other threads:[~2010-01-29 15:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  2:13 Mark Lord
2010-01-27 12:08 ` Mel Gorman
2010-01-27 22:39   ` Mark Lord
2010-01-28  1:04     ` David Rientjes
2010-01-28  3:32       ` Mark Lord
2010-01-28  4:17     ` Mark Lord
2010-01-28  4:34       ` Mark Lord
2010-01-28  9:01         ` Mike Galbraith
2010-01-28 10:52         ` Rafael J. Wysocki
2010-01-28 13:51           ` Mark Lord
2010-01-28 14:17             ` Mark Lord
2010-01-28 14:24               ` Mel Gorman
2010-01-29 13:56                 ` Mark Lord
2010-01-29 15:46                   ` Mel Gorman [this message]
2010-01-29 17:27                     ` Hugh Dickins
2010-01-29 17:34                       ` Mel Gorman
2010-01-29 17:46                         ` [PATCH] mm: fix migratetype bug which slowed swapping Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100129154653.GJ7139@csn.ul.ie \
    --to=mel@csn.ul.ie \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=kernel@teksavvy.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome