From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alessio Igor Bogani <abogani@texware.it>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alessio Igor Bogani <abogani@texware.it>,
Greg Kroah-Hartman <gregkh@suse.de>,
Johan Hovold <jhovold@gmail.com>, Alan Cox <alan@linux.intel.com>,
Daniel Mack <daniel@caiaq.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] USB: ftdi_sio: Remove BKL
Date: Tue, 2 Feb 2010 14:13:20 +0000 [thread overview]
Message-ID: <20100202141320.38e89229@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1265119094-3356-1-git-send-email-abogani@texware.it>
On Tue, 2 Feb 2010 14:58:14 +0100
Alessio Igor Bogani <abogani@texware.it> wrote:
> Seems to me that BKL don't protect nothing here anymore. So I would want suggest to remove it.
What now stops parallel calls to the config ioctl making a nasty mess ?
The current locking is broken certainly, but removing it is not the fix
(the speed locking is broken too on that path I notice)
Alan
next prev parent reply other threads:[~2010-02-02 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 13:58 Alessio Igor Bogani
2010-02-02 14:13 ` Alan Cox [this message]
2010-02-02 15:18 ` [PATCH] USB: ftdi_sio: Replace BKL with a mutex Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100202141320.38e89229@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=abogani@texware.it \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=daniel@caiaq.de \
--cc=gregkh@suse.de \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®