From: Andi Kleen <andi@firstfloor.org>
To: submit@firstfloor.org, linux-kernel@vger.kernel.org,
haicheng.li@intel.com, penberg@cs.helsinki.fi,
linux-mm@kvack.org
Subject: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap
Date: Wed, 3 Feb 2010 22:39:15 +0100 (CET) [thread overview]
Message-ID: <20100203213915.DB0EBB1620@basil.firstfloor.org> (raw)
In-Reply-To: <201002031039.710275915@firstfloor.org>
cache_reap can run before the node is set up and then reference a NULL
l3 list. Check for this explicitely and just continue. The node
will be eventually set up.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
mm/slab.c | 3 +++
1 file changed, 3 insertions(+)
Index: linux-2.6.33-rc3-ak/mm/slab.c
===================================================================
--- linux-2.6.33-rc3-ak.orig/mm/slab.c
+++ linux-2.6.33-rc3-ak/mm/slab.c
@@ -4112,6 +4112,9 @@ static void cache_reap(struct work_struc
* we can do some work if the lock was obtained.
*/
l3 = searchp->nodelists[node];
+ /* Note node yet set up */
+ if (!l3)
+ break;
reap_alien(searchp, l3);
next prev parent reply other threads:[~2010-02-03 21:39 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 21:39 [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues Andi Kleen
2010-02-03 21:39 ` [PATCH] [1/4] SLAB: Handle node-not-up case in fallback_alloc() Andi Kleen
2010-02-05 21:06 ` David Rientjes
2010-02-06 7:25 ` Andi Kleen
2010-02-06 9:53 ` David Rientjes
2010-02-06 15:56 ` Andi Kleen
2010-02-06 22:31 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [2/4] SLAB: Set up the l3 lists for the memory of freshly added memory Andi Kleen
2010-02-05 19:12 ` Christoph Lameter
2010-02-05 21:17 ` David Rientjes
2010-02-06 7:26 ` Andi Kleen
2010-02-06 9:47 ` David Rientjes
2010-02-03 21:39 ` [PATCH] [3/4] SLAB: Separate node initialization into separate function Andi Kleen
2010-02-05 19:15 ` Christoph Lameter
2010-02-05 21:29 ` David Rientjes
2010-02-06 7:27 ` Andi Kleen
2010-02-06 9:55 ` David Rientjes
2010-02-03 21:39 ` Andi Kleen [this message]
2010-02-05 19:16 ` [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap Christoph Lameter
2010-02-05 8:27 ` [PATCH] [0/4] SLAB: Fix a couple of slab memory hotadd issues Pekka Enberg
2010-02-05 19:19 ` Christoph Lameter
2010-02-05 20:22 ` Andi Kleen
2010-02-05 20:55 ` Christoph Lameter
2010-02-11 20:53 [PATCH] [0/4] Update slab memory hotplug series Andi Kleen
2010-02-11 20:54 ` [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap Andi Kleen
2010-02-11 21:45 ` David Rientjes
2010-02-15 6:15 ` Nick Piggin
2010-02-15 10:32 ` Andi Kleen
2010-02-15 10:41 ` Nick Piggin
2010-02-15 10:52 ` Andi Kleen
2010-02-15 11:01 ` Nick Piggin
2010-02-15 15:30 ` Andi Kleen
2010-02-19 18:22 ` Christoph Lameter
2010-02-20 9:01 ` Andi Kleen
2010-02-22 10:53 ` Pekka Enberg
2010-02-22 14:31 ` Andi Kleen
2010-02-22 16:11 ` Pekka Enberg
2010-02-22 20:20 ` Andi Kleen
2010-02-24 15:49 ` Christoph Lameter
2010-02-25 7:26 ` Pekka Enberg
2010-02-25 8:01 ` David Rientjes
2010-02-25 18:30 ` Christoph Lameter
2010-02-25 21:45 ` David Rientjes
2010-02-25 22:31 ` Christoph Lameter
2010-02-26 10:45 ` Pekka Enberg
2010-02-26 11:43 ` Andi Kleen
2010-02-26 12:35 ` Pekka Enberg
2010-02-26 14:08 ` Andi Kleen
2010-02-26 1:09 ` KAMEZAWA Hiroyuki
2010-02-26 11:41 ` Andi Kleen
2010-02-26 15:04 ` Christoph Lameter
2010-02-26 15:05 ` Christoph Lameter
2010-02-26 15:59 ` Andi Kleen
2010-02-26 15:57 ` Andi Kleen
2010-02-26 17:24 ` Christoph Lameter
2010-02-26 17:31 ` Andi Kleen
2010-03-01 1:59 ` KAMEZAWA Hiroyuki
2010-03-01 10:27 ` David Rientjes
2010-02-27 0:01 ` David Rientjes
2010-02-25 18:34 ` Christoph Lameter
2010-02-25 18:46 ` Pekka Enberg
2010-02-25 19:19 ` Christoph Lameter
2010-03-02 12:55 ` Andi Kleen
2010-02-19 18:22 ` Christoph Lameter
2010-02-22 10:57 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203213915.DB0EBB1620@basil.firstfloor.org \
--to=andi@firstfloor.org \
--cc=haicheng.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=submit@firstfloor.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome