mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: s.L-H@gmx.de
Cc: hadi@cyberus.ca, gregkh@suse.de, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: patch net-restore-ip-source-validation.patch added to 2.6.32-stable tree
Date: Thu, 04 Feb 2010 12:03:09 -0800 (PST)	[thread overview]
Message-ID: <20100204.120309.51395616.davem@davemloft.net> (raw)
In-Reply-To: <201002042049.31582.s.L-H@gmx.de>

From: "Stefan Lippers-Hollmann" <s.L-H@gmx.de>
Date: Thu, 4 Feb 2010 20:49:29 +0100

> --- a/include/linux/sysctl.h
> +++ b/include/linux/sysctl.h
> @@ -490,6 +490,7 @@ enum
>  	NET_IPV4_CONF_PROMOTE_SECONDARIES=20,
>  	NET_IPV4_CONF_ARP_ACCEPT=21,
>  	NET_IPV4_CONF_ARP_NOTIFY=22,
> +	NET_IPV4_CONF_ACCEPT_LOCAL=23,
>  	NET_IPV4_CONF_SRC_VMARK=24,
>  	__NET_IPV4_CONF_MAX
>  };
> 
> isn't sufficient, 2.6.32.8-rc1 plus the suggested patch above fails to boot
> as well (this time on amd64):

Yeah you can't just add the sysctl value without filling in the
name string in net/ipv4/devinet.c like the rest of Patrick's
change did.

Maybe just using a value of 23 for NET_IPV4_CONF_SRC_VMARK
will work best, can you try that?

Thanks.

  parent reply	other threads:[~2010-02-04 20:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1265060041850@kroah.org>
2010-02-03 20:14 ` Stefan Lippers-Hollmann
2010-02-04 11:13   ` jamal
2010-02-04 17:50     ` Stefan Lippers-Hollmann
2010-02-04 18:14       ` jamal
2010-02-04 18:19         ` David Miller
2010-02-04 18:29           ` jamal
2010-02-04 18:31         ` Stefan Lippers-Hollmann
2010-02-04 18:38           ` jamal
2010-02-04 19:49             ` Stefan Lippers-Hollmann
2010-02-04 19:57               ` jamal
2010-02-04 20:03               ` David Miller [this message]
2010-02-04 19:50             ` jamal
2010-02-04 20:03               ` David Miller
2010-02-05 16:50                 ` Greg KH
2010-02-04 20:24               ` Stefan Lippers-Hollmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100204.120309.51395616.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=hadi@cyberus.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.L-H@gmx.de \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome