From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756014Ab0BJUZ3 (ORCPT ); Wed, 10 Feb 2010 15:25:29 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59234 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755892Ab0BJUZ0 (ORCPT ); Wed, 10 Feb 2010 15:25:26 -0500 Date: Wed, 10 Feb 2010 12:25:40 -0800 (PST) Message-Id: <20100210.122540.149553948.davem@davemloft.net> To: linville@tuxdriver.com Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mb@bu3sch.de Subject: Re: pull request: wireless-2.6 2010-02-10 From: David Miller In-Reply-To: <20100210201953.GC3286@tuxdriver.com> References: <1265829337.19075.0.camel@jlt3.sipsolutions.net> <20100210.113658.137273026.davem@davemloft.net> <20100210201953.GC3286@tuxdriver.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "John W. Linville" Date: Wed, 10 Feb 2010 15:19:54 -0500 > On Wed, Feb 10, 2010 at 11:36:58AM -0800, David Miller wrote: >> From: Johannes Berg >> Date: Wed, 10 Feb 2010 20:15:37 +0100 >> >> > It was intentional -- that sdev doesn't even have an irq member, but >> > nobody ever noticed because of the wrong ifdef. >> >> Ok, then this needs to be explained in the commit message. > > OK...mind if I just revert the current version and ask Michael to > resubmit with an appropriate changelog entry? Have you pulled this tree into others already? Why not just pop out the commit and fix it's commit message, then reapply? Having the revert commit in there is really stupid just for this.