mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Finn Thain <fthain@telegraphics.com.au>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: linux-next: manual merge of the devicetree tree with the m68k tree
Date: Wed, 10 Feb 2010 16:02:34 +1100	[thread overview]
Message-ID: <20100210160234.673f32d1.sfr@canb.auug.org.au> (raw)

Hi Grant,

Today's linux-next merge of the devicetree tree got a conflict in
drivers/serial/pmac_zilog.c between commit
f0ccf0f0269dfe53ec3f1c58fe130a47b908b907 ("pmac-zilog: cleanup") from
the m68k tree and commit71a157e8edca55198e808f8561dd49017a54ee34  ("of: add
'of_' prefix to machine_is_compatible()") from the devicetree tree.

The first removes a space ... I fixed it up (see below) and can carry the
fix as necessary.  (Grant, you could get rid of this by removing the
space between the tabs on the line "baud = 57600;".  Not a big issue,
though.)

Also, there is a further patch in the m68k tree
(89d58f83cfce675a2054975cc2598ba1979816c7 "pmac-zilog: add platform
driver") that adds a define for machine_is_compatible.  I fixed that as
below as well.  Hmmm, this file should really include linux/of_fdt.h for
the definition of of_machine_is_compatible(), shouldn't it?  And then
maybe we could have a non OF version of the prototype/define in
of_fdt.h?  Just an idea.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/serial/pmac_zilog.c
index 870b6a3,3e2ae48..0000000
--- a/drivers/serial/pmac_zilog.c
+++ b/drivers/serial/pmac_zilog.c
@@@ -70,10 -68,6 +70,10 @@@
  #include <asm/pmac_feature.h>
  #include <asm/dbdma.h>
  #include <asm/macio.h>
 +#else
 +#include <linux/platform_device.h>
- #define machine_is_compatible(x) (0)
++#define of_machine_is_compatible(x) (0)
 +#endif
  
  #if defined (CONFIG_SERIAL_PMACZILOG_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
  #define SUPPORT_SYSRQ
@@@ -2145,10 -2031,10 +2145,10 @@@ static int __init pmz_console_setup(str
  	/*
  	 * XServe's default to 57600 bps
  	 */
- 	if (machine_is_compatible("RackMac1,1")
- 	    || machine_is_compatible("RackMac1,2")
- 	    || machine_is_compatible("MacRISC4"))
+ 	if (of_machine_is_compatible("RackMac1,1")
+ 	    || of_machine_is_compatible("RackMac1,2")
+ 	    || of_machine_is_compatible("MacRISC4"))
 -	 	baud = 57600;
 +		baud = 57600;
  
  	/*
  	 * Check whether an invalid uart number has been specified, and

             reply	other threads:[~2010-02-10  5:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10  5:02 Stephen Rothwell [this message]
2010-02-10 20:17 ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100210160234.673f32d1.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=fthain@telegraphics.com.au \
    --cc=geert@linux-m68k.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®