mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Endriss <o.endriss@gmx.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: mchehab@redhat.com, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, jirislaby@gmail.com,
	Matthias Benesch <twoof7@freenet.de>,
	Ralph Metzler <rjkm@metzlerbros.de>
Subject: Re: [PATCH 1/1] DVB: ngene, fix memset parameters
Date: Thu, 11 Feb 2010 05:20:50 +0100	[thread overview]
Message-ID: <201002110520.55301@orion.escape-edv.de> (raw)
In-Reply-To: <1265844762-17730-1-git-send-email-jslaby@suse.cz>

Jiri Slaby wrote:
> Switch second and third memset parameter to stamp the length buffer bytes
> by 0xff's, not 255 bytes by low 8 bits of Length.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Matthias Benesch <twoof7@freenet.de>
> Cc: Ralph Metzler <rjkm@metzlerbros.de>
> Cc: Oliver Endriss <o.endriss@gmx.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
>  drivers/media/dvb/ngene/ngene-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index cb5982e..0150dfe 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
>  {
>  	u32 *ptr = Buffer;
>  
> -	memset(Buffer, Length, 0xff);
> +	memset(Buffer, 0xff, Length);
>  	while (Length > 0) {
>  		if (Flags & DF_SWAP32)
>  			*ptr = 0x471FFF10;
> -- 
> 1.6.6.1

Acked-by: Oliver Endriss <o.endriss@gmx.de>

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------

      reply	other threads:[~2010-02-11  4:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10 23:32 Jiri Slaby
2010-02-11  4:20 ` Oliver Endriss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002110520.55301@orion.escape-edv.de \
    --to=o.endriss@gmx.de \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=rjkm@metzlerbros.de \
    --cc=twoof7@freenet.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®