From: Oliver Neukum <oliver@neukum.org>
To: David Fries <david@fries.net>
Cc: Jiri Kosina <jkosina@suse.cz>,
USB list <linux-usb@vger.kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: usbhid control queue full, due to stuck control request
Date: Fri, 12 Feb 2010 08:35:36 +0100 [thread overview]
Message-ID: <201002120835.36908.oliver@neukum.org> (raw)
In-Reply-To: <20100212004910.GD22311@spacedout.fries.net>
Am Freitag, 12. Februar 2010 01:49:10 schrieb David Fries:
> Oliver Neukum, this is based on your patch, do you agree with the
> changes?
I do agree.
> One possible problem with this fix is it drops the stalled URB
> transfer. That might pose a problem for one shot messages, possibly
> hid_ctrl and hid_irq_out could resubmit the same urb when -ECONNRESET
> is received, assuming the message content wasn't the reason it
> timedout in the first place.
That is a big assumption. Realistically, if the hardware needs over 5s
to answer the hardware is buggy. We are working around that. It is best
to get not too fancy, unless testing shows that we need to.
Regards
Oliver
next prev parent reply other threads:[~2010-02-12 7:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100206172051.GA22311@spacedout.fries.net>
[not found] ` <201002081256.01614.oliver@neukum.org>
[not found] ` <20100209023508.GB22311@spacedout.fries.net>
[not found] ` <20100211010450.GC22311@spacedout.fries.net>
[not found] ` <alpine.LRH.2.00.1002111617290.16183@twin.jikos.cz>
2010-02-12 0:49 ` David Fries
2010-02-12 7:35 ` Oliver Neukum [this message]
2010-02-12 11:57 ` Jiri Kosina
2010-02-12 11:59 ` Oliver Neukum
2010-02-12 12:01 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002120835.36908.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=david@fries.net \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®