From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
To: Samuel Ortiz <sameo@linux.intel.com>,
Balaji T K <balajitk@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Rajendra Nayak <rnayak@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
linux-kernel@vger.kernel.org
Cc: vamos@i4.informatik.uni-erlangen.de
Subject: [PATCH] typo in kernel source (INPUT_TWL4030_PWBUTTON) (resend)
Date: Fri, 12 Feb 2010 16:19:46 +0100 [thread overview]
Message-ID: <20100212151946.GA2502@faui49.informatik.uni-erlangen.de> (raw)
Hi all!
Accoring to my mail-log and a quick look at the mfd tree this
patch seems to have been lost. I guess it just has been missed among
other stuff or is anything wrong with it?
----
As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.
While working on this we detected a spelling error in
drivers/mfd/twl-core.c which can be corrected using the attached
patch.
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
[0] http://vamos1.informatik.uni-erlangen.de/
----
>From 83cadb82b627f35333742d1585c2f63e40e76ef4 Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Date: Wed, 13 Jan 2010 10:56:27 +0100
Subject: [PATCH] Correct spelling for config INPUT_TWL4030_PWRBUTTON
While the non-module variant of the TWL4030 Powerbutton is querried
with INPUT_TWL4030_PWRBUTTON, the _MODULE variant misses the R and is
checking therefor INPUT_TWL4030_PWBUTTON which won't work as there's
nosuch option in kconfig
Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
---
drivers/mfd/twl-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 2a76065..aeaeac4 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -129,7 +129,7 @@
#define TWL_NUM_SLAVES 4
#if defined(CONFIG_INPUT_TWL4030_PWRBUTTON) \
- || defined(CONFIG_INPUT_TWL4030_PWBUTTON_MODULE)
+ || defined(CONFIG_INPUT_TWL4030_PWRBUTTON_MODULE)
#define twl_has_pwrbutton() true
#else
#define twl_has_pwrbutton() false
--
1.6.3.3
next reply other threads:[~2010-02-12 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 15:19 Christoph Egger [this message]
2010-02-12 16:19 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212151946.GA2502@faui49.informatik.uni-erlangen.de \
--to=siccegge@stud.informatik.uni-erlangen.de \
--cc=balajitk@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=vamos@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®