mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kirill Smelkov <kirr@landau.phys.spbu.ru>
To: acme@redhat.com, mingo@redhat.com, mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, efault@gmx.de,
	tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf top: Fix annotate for userspace
Date: Fri, 12 Feb 2010 19:20:59 +0300	[thread overview]
Message-ID: <20100212162059.GA30041@landau.phys.spbu.ru> (raw)
In-Reply-To: <tip-ee11b90b12eb1ec25e1044bac861e90bfd19ec9e@git.kernel.org>

On Sun, Feb 07, 2010 at 04:33:40PM +0000, tip-bot for Kirill Smelkov wrote:
> Commit-ID:  ee11b90b12eb1ec25e1044bac861e90bfd19ec9e
> Gitweb:     http://git.kernel.org/tip/ee11b90b12eb1ec25e1044bac861e90bfd19ec9e
> Author:     Kirill Smelkov <kirr@landau.phys.spbu.ru>
> AuthorDate: Sun, 7 Feb 2010 11:46:15 -0200
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Sun, 7 Feb 2010 17:30:20 +0100
> 
> perf top: Fix annotate for userspace

[...]

Arnaldo, Ingo, thanks for finally applying it

  ( though shouldn't, AuthorDate be ``Fri,  8 Jan 2010 15:23:08 +0300'',
    just like in my post for this patch
    http://marc.info/?l=linux-kernel&m=126295508002536&w=2 ?)

----

Also, could you please apply one last cosmetic patch from my original
series

http://marc.info/?l=linux-kernel&m=126295502702502&w=2


That would logically complete my holiday journey to perf land.


For convenience I'm providing this one last patch here (applies to
tip/master cleanly).


Thanks beforehand,
Kirill


From: Kirill Smelkov <kirr@landau.phys.spbu.ru>
Subject: [PATCH 2/6] perf top: align help text on keys
Date: Fri,  8 Jan 2010 15:23:05 +0300

Mapped keys:
        [d]     display refresh delay.                  (2)
        [e]     display entries (lines).                (46)
        [f]     profile display filter (count).         (5)
        [F]     annotate display filter (percent).      (5%)
        [s]     annotate symbol.                        (NULL)
        [S]     stop annotation.
        [K]     hide kernel_symbols symbols.            (no)
        [U]     hide user symbols.                      (no)
        [z]     toggle sample zeroing.                  (0)
        [qQ]    quit.

instead of

Mapped keys:
        [d]     display refresh delay.                  (2)
        [e]     display entries (lines).                (46)
        [f]     profile display filter (count).         (5)
        [F]     annotate display filter (percent).      (5%)
        [s]     annotate symbol.                        (NULL)
        [S]     stop annotation.
        [K]     hide kernel_symbols symbols.                    (no)
        [U]     hide user symbols.                      (no)
        [z]     toggle sample zeroing.                  (0)
        [qQ]    quit.

Signed-off-by: Kirill Smelkov <kirr@landau.phys.spbu.ru>
---
 tools/perf/builtin-top.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 9c7de93..9dc8070 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -704,7 +704,7 @@ static void print_mapped_keys(void)
 		fprintf(stdout, "\t[w]     toggle display weighted/count[E]r. \t(%d)\n", display_weighted ? 1 : 0);
 
 	fprintf(stdout,
-		"\t[K]     hide kernel_symbols symbols.             \t(%s)\n",
+		"\t[K]     hide kernel_symbols symbols.     \t(%s)\n",
 		hide_kernel_symbols ? "yes" : "no");
 	fprintf(stdout,
 		"\t[U]     hide user symbols.               \t(%s)\n",
-- 
1.6.6.79.gd514e.dirty


  reply	other threads:[~2010-02-12 16:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 13:46 [PATCH 1/2] perf top: fix " Arnaldo Carvalho de Melo
2010-02-07 13:46 ` [PATCH 2/2] perf top: Use address pattern in lookup_sym_source Arnaldo Carvalho de Melo
2010-02-07 16:33 ` [tip:perf/core] perf top: Fix annotate for userspace tip-bot for Kirill Smelkov
2010-02-12 16:20   ` Kirill Smelkov [this message]
2010-02-12 18:53     ` Arnaldo Carvalho de Melo
2010-02-14  9:13     ` [tip:perf/urgent] perf top: Fix help text alignment tip-bot for Kirill Smelkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100212162059.GA30041@landau.phys.spbu.ru \
    --to=kirr@landau.phys.spbu.ru \
    --cc=acme@redhat.com \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®