From: Oliver Neukum <oliver@neukum.org>
To: Graham M Howe <gman.1352@googlemail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: fix bracing and 80 character stylein ni_at_a2150.c This is a patch to the ni_at_a2150.c file to fix up bracing and 80 character warnings found by the checkpatch.pl tool Signed-off-by: Graham M Howe <gman.1352@googlemail.com>
Date: Sat, 13 Feb 2010 00:07:38 +0100 [thread overview]
Message-ID: <201002130007.38863.oliver@neukum.org> (raw)
In-Reply-To: <1266015937-3532-1-git-send-email-user@graham-eeepc>
Am Samstag, 13. Februar 2010 00:05:37 schrieb Graham M Howe:
> --- a/drivers/staging/comedi/drivers/ni_at_a2150.c
> +++ b/drivers/staging/comedi/drivers/ni_at_a2150.c
> @@ -86,8 +86,10 @@ TRIG_WAKE_EOS
> #define CLOCK_SELECT_BITS(x) (((x) & 0x3) << 3)
> #define CLOCK_DIVISOR_BITS(x) (((x) & 0x3) << 5)
> #define CLOCK_MASK (0xf << 3)
> -#define ENABLE0_BIT 0x80 /* enable (don't internally ground) channels 0 and 1 */
> -#define ENABLE1_BIT 0x100 /* enable (don't internally ground) channels 2 and 3 */
> +/* enable (don't internally ground) channels 0 and 1 */
> +#define ENABLE0_BIT 0x80
> +/* enable (don't internally ground) channels 2 and 3 */
Does this really improve readability?
Regards
Oliver
prev parent reply other threads:[~2010-02-12 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 23:05 Graham M Howe
2010-02-12 23:07 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002130007.38863.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=devel@driverdev.osuosl.org \
--cc=gman.1352@googlemail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®