mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Joe Perches <joe@perches.com>
Cc: Tilman Schmidt <tilman@imap.cc>,
	David Miller <davem@davemloft.net>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level>
Date: Sun, 14 Feb 2010 19:09:06 -0800	[thread overview]
Message-ID: <201002141909.06541.david-b@pacbell.net> (raw)
In-Reply-To: <1266195287.16721.953.camel@Joe-Laptop.home>

On Sunday 14 February 2010, Joe Perches wrote:
> I'll resend in a bit after David Brownell or
> someone else answers the inverted question below.
> 
> > Btw, is it intentional that the _OTHER values are printed after the
> > label "this", and the _THIS values after the label "other"?
> 
> Thanks again, I saw that, but neglected to mention it.
> David Brownell?  Do you know if that is inverted?

I'd call that a bug.  Note that this is specific to the net1080
chip, which hasn't been manufactured for quite a few years now
and was never hugely popular ... so the significance of getting
that rarely-seen diagnostic wrong was minor.

- Dave




  reply	other threads:[~2010-02-15  3:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10  1:43 [PATCH] usbnet: convert dev(dbg|err|warn|info) macros to usbnet_(dbg|err|warn|info) Joe Perches
2010-02-10  5:53 ` David Brownell
2010-02-10  6:16   ` Joe Perches
2010-02-10  6:56     ` David Brownell
2010-02-12 20:38       ` David Miller
2010-02-14 23:01         ` [net-next PATCH 0/2] usbnet: convert dev(dbg|err|warn|info) macros to netdev_<> Joe Perches
2010-02-14 23:01           ` [PATCH 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level> Joe Perches
2010-02-15  0:17             ` Tilman Schmidt
2010-02-15  0:54               ` Joe Perches
2010-02-15  3:09                 ` David Brownell [this message]
2010-02-14 23:01           ` [PATCH 2/2] drivers/net/usb: Use netif_<level> logging facilities Joe Perches
2010-02-15  8:25         ` [PATCH V2 net-next 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level> Joe Perches
2010-02-17  7:37           ` David Miller
2010-02-17  8:04             ` David Miller
2010-02-17 20:30               ` [PATCH V3 net-next 0/2] usbnet: Use (netdev|netif)_<level> macros Joe Perches
2010-02-17 20:30                 ` [PATCH V3 net-next 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level> Joe Perches
2010-02-17 20:30                 ` [PATCH V3 net-next 2/2] drivers/net/usb: Use netif_<level> logging facilities Joe Perches
2010-02-17 21:38                 ` [PATCH V3 net-next 0/2] usbnet: Use (netdev|netif)_<level> macros David Miller
2010-02-17 21:44                   ` Joe Perches
2010-02-17 21:54                     ` David Miller
2010-02-15  8:25         ` [PATCH V2 net-next 2/2] drivers/net/usb: Use netif_<level> logging facilities Joe Perches
2010-02-17  7:37           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002141909.06541.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome