From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Justin Piszcz <jpiszcz@lucidpixels.com>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernl.org,
xfs@oss.sgi.com, Alan Piszcz <ap@solarrain.com>
Subject: Re: 2.6.32.3 x86_64 - XFS hangs, all I/O to D-state bug (again)
Date: Mon, 15 Feb 2010 09:02:29 +1100 [thread overview]
Message-ID: <20100214220229.GB28392@discord.disaster> (raw)
In-Reply-To: <20100211145123.GA13114@infradead.org>
On Thu, Feb 11, 2010 at 09:51:23AM -0500, Christoph Hellwig wrote:
> Can you check if this still happens with the patch below?
>
>
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_buf.c 2010-02-11 15:47:49.677253958 +0100
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_buf.c 2010-02-11 15:48:03.630005040 +0100
> @@ -1158,8 +1158,7 @@ _xfs_buf_ioapply(
> bp->b_flags &= ~_XBF_RUN_QUEUES;
> rw = (bp->b_flags & XBF_WRITE) ? WRITE_META : READ_META;
> } else {
> - rw = (bp->b_flags & XBF_WRITE) ? WRITE :
> - (bp->b_flags & XBF_READ_AHEAD) ? READA : READ;
> + rw = (bp->b_flags & XBF_WRITE) ? WRITE : READ;
> }
We don't ever issue readahead on the AGF buffers, so I'm not sure
this will fix the hang. More often than not a hang like this
is caused by a write IO completion not occurring....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2010-02-14 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 14:09 Justin Piszcz
2010-02-11 14:13 ` Justin Piszcz
2010-02-11 14:23 ` Justin Piszcz
2010-02-11 14:35 ` Justin Piszcz
2010-02-11 14:51 ` Christoph Hellwig
2010-02-11 14:56 ` Christoph Hellwig
2010-02-14 22:02 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100214220229.GB28392@discord.disaster \
--to=david@fromorbit.com \
--cc=ap@solarrain.com \
--cc=hch@infradead.org \
--cc=jpiszcz@lucidpixels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernl.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®