From: Jouni Malinen <j@w1.fi>
To: Michael Neuling <mikey@neuling.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
anton@samba.org
Subject: Re: 2.6.33-rc8 breaks UML with Restrict initial stack space expansion to rlimit
Date: Mon, 15 Feb 2010 09:12:15 +0200 [thread overview]
Message-ID: <20100215071215.GA20814@jm.kir.nu> (raw)
In-Reply-To: <12468.1266215420@neuling.org>
On Mon, Feb 15, 2010 at 05:30:20PM +1100, Michael Neuling wrote:
> We got the logic wrong in one of the cleanups and hence we aren't
> actually changing the stack reservation ever, when we intended on
> allocating up to 20 new pages.
>
> The:
> rlim_stack = min(rlim_stack, stack_size);
> always chooses stack_size hence we end up not changing the stack at all.
> This seems to cause fatal problems on UML, but is obviously not what was
> intended for archs as well.
>
> The following works for me on PPC64 64k and 4k pages and UML on x86_64.
That fixes my UML setup, too.
--
Jouni Malinen PGP id EFC895FA
prev parent reply other threads:[~2010-02-15 7:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 16:40 Jouni Malinen
2010-02-14 22:03 ` Michael Neuling
2010-02-15 2:38 ` KOSAKI Motohiro
2010-02-15 7:02 ` Jouni Malinen
2010-02-15 6:56 ` Jouni Malinen
2010-02-14 23:23 ` Rafael J. Wysocki
2010-02-15 6:30 ` Michael Neuling
2010-02-15 6:59 ` KOSAKI Motohiro
2010-02-15 7:17 ` Jouni Malinen
2010-02-15 8:57 ` [PATCH] exec/fs: fix initial stack reservation Michael Neuling
2010-02-15 9:04 ` KOSAKI Motohiro
2010-02-15 9:08 ` Américo Wang
2010-02-15 8:57 ` 2.6.33-rc8 breaks UML with Restrict initial stack space expansion to rlimit Américo Wang
2010-02-15 9:03 ` KOSAKI Motohiro
2010-02-15 7:12 ` Jouni Malinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215071215.GA20814@jm.kir.nu \
--to=j@w1.fi \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®