From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757081Ab0BPRaZ (ORCPT ); Tue, 16 Feb 2010 12:30:25 -0500 Received: from mail-vw0-f46.google.com ([209.85.212.46]:33814 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757036Ab0BPRaW (ORCPT ); Tue, 16 Feb 2010 12:30:22 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=NFd5/W+i+z8rjT+PiaWT8EDp+Cj+JhotOXMAkYdDWZJ77ejVaHRrkFTPhaCJekeu/D 1qZWdvnnqIyUoD1Vf2G4VHvN0cDQgyaBJ89o/w7UltVSS6afpmf56ItAU8rCORNsQ2Bw c64Fg4lX6FVbbyU46uY1y8cqIbGBgg+afHMAo= Date: Tue, 16 Feb 2010 09:30:10 -0800 From: Dmitry Torokhov To: Jiri Slaby Cc: mchehab@redhat.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com, Mauro Carvalho Chehab Subject: Re: [PATCH] V4L: dvb-usb, add extra sync to down-up input events Message-ID: <20100216173010.GA15376@core.coreip.homeip.net> References: <1266179785-836-1-git-send-email-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1266179785-836-1-git-send-email-jslaby@suse.cz> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Sun, Feb 14, 2010 at 09:36:25PM +0100, Jiri Slaby wrote: > Userspace is allowed to coalesce events between SYNCs. And since the code > emits UP right after DOWN for the same key, it may be missed > (up+down=nothing). Add an extra sync in between UP and DOWN events to disable > the coalesce. > > Signed-off-by: Jiri Slaby Looks good. Acked-by: Dmitry Torokhov > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > --- > drivers/media/dvb/dvb-usb/dib0700_core.c | 1 + > drivers/media/dvb/dvb-usb/dvb-usb-remote.c | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/media/dvb/dvb-usb/dib0700_core.c b/drivers/media/dvb/dvb-usb/dib0700_core.c > index 4450214..4f961d2 100644 > --- a/drivers/media/dvb/dvb-usb/dib0700_core.c > +++ b/drivers/media/dvb/dvb-usb/dib0700_core.c > @@ -612,6 +612,7 @@ static void dib0700_rc_urb_completion(struct urb *purb) > case REMOTE_KEY_REPEAT: > deb_info("key repeated\n"); > input_event(d->rc_input_dev, EV_KEY, event, 1); > + input_sync(d->rc_input_dev); > input_event(d->rc_input_dev, EV_KEY, d->last_event, 0); > input_sync(d->rc_input_dev); > break; > diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-remote.c b/drivers/media/dvb/dvb-usb/dvb-usb-remote.c > index 6b5ded9..a03ef7e 100644 > --- a/drivers/media/dvb/dvb-usb/dvb-usb-remote.c > +++ b/drivers/media/dvb/dvb-usb/dvb-usb-remote.c > @@ -107,6 +107,7 @@ static void dvb_usb_read_remote_control(struct work_struct *work) > case REMOTE_KEY_REPEAT: > deb_rc("key repeated\n"); > input_event(d->rc_input_dev, EV_KEY, event, 1); > + input_sync(d->rc_input_dev); > input_event(d->rc_input_dev, EV_KEY, d->last_event, 0); > input_sync(d->rc_input_dev); > break; > -- > 1.6.6.1 > -- Dmitry