From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Alan Cox <alan@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] vt: Fix refcounting use
Date: Wed, 17 Feb 2010 16:31:35 +0000 [thread overview]
Message-ID: <20100217163135.120c4bc1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4B7C0DBB.5010801@rsk.demon.co.uk>
> This is the only bit that immediately stands out..
> maybe?
> if (rep || !tty) {
> if (tty)
> tty_kref_put(tty);
> return;
> }
tty_kref_put(NULL) is valid - otherwise a lot of other code (and
programmers) would go nuts..
Alan
prev parent reply other threads:[~2010-02-17 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 13:22 [RFC 0/3] A little console mystery Alan Cox
2010-02-17 13:23 ` [PATCH 1/3] tty: Make vt's have a tty_port Alan Cox
2010-02-17 13:23 ` [PATCH 2/3] tty: Move the vt_tty field from the vc_data into the standard tty_port Alan Cox
2010-02-17 13:23 ` [PATCH 3/3] vt: Fix refcounting use Alan Cox
2010-02-17 15:39 ` Richard Kennedy
2010-02-17 16:31 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217163135.120c4bc1@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®