From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>, "Jon D. Mason" <jdmason@kudzu.us>,
discuss@x86-64.org, Corinna Schultz <coschult@us.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] calgary: Increase the maximum PHB bus number
Date: Thu, 18 Feb 2010 10:37:50 -0800 [thread overview]
Message-ID: <20100218183750.GL29604@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20091209090346.GN2452@tyrion.haifa.ibm.com>
On Wed, Dec 09, 2009 at 11:03:46AM +0200, Muli Ben-Yehuda wrote:
> On Tue, Dec 08, 2009 at 04:59:01PM -0800, Darrick J. Wong wrote:
>
> > -#define MAX_NUM_OF_PHBS 8 /* how many PHBs in total? */
> > -#define MAX_NUM_CHASSIS 8 /* max number of chassis */
> > -/* MAX_PHB_BUS_NUM is the maximal possible dev->bus->number */
> > -#define MAX_PHB_BUS_NUM (MAX_NUM_OF_PHBS * MAX_NUM_CHASSIS * 2)
> > +/*
> > + The maximum PHB bus number.
> > + x3950M2 (rare): 8 chassis, 48 PHBs per chassis = 384
> > + x3950M2: 4 chassis, 48 PHBs per chassis = 192
> > + x3950 (PCIE): 8 chassis, 32 PHBs per chassis = 256
> > + x3950 (PCIX): 8 chassis, 16 PHBs per chassis = 128
> > +*/
> > +#define MAX_PHB_BUS_NUM 384
> > +
> > #define PHBS_PER_CALGARY 4
>
> We'll end up wasting a few bytes on small systems, but I don't think
> it's enough to matter on these fairly large systems. As far as I'm
> concerned, patch is fine.
>
> Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
Hmm... has this patch been queued up by anyone for the .34 merge window?
--D
next prev parent reply other threads:[~2010-02-18 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 0:59 Darrick J. Wong
2009-12-09 5:04 ` Jon Mason
2009-12-09 18:40 ` [PATCH v2] " Darrick J. Wong
2009-12-09 19:37 ` Jon Mason
[not found] ` <20091209090346.GN2452@tyrion.haifa.ibm.com>
2010-02-18 18:37 ` Darrick J. Wong [this message]
2010-02-20 7:18 ` [PATCH] " Muli Ben-Yehuda
2010-04-06 18:09 ` Darrick J. Wong
2010-05-24 23:52 Corinna Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218183750.GL29604@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=coschult@us.ibm.com \
--cc=discuss@x86-64.org \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®