From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "masa-korg" <masa-korg@dsn.okisemi.com>
Cc: <linux-kernel@vger.kernel.org>, <andrew.chih.howe.khor@intel.com>,
<joel.clark@intel.com>
Subject: Re: [PATCH]Add new device drivers for Topcliff
Date: Fri, 19 Feb 2010 15:29:07 +0000 [thread overview]
Message-ID: <20100219152907.75065c83@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <000a01cab118$8bbc8600$66f8800a@maildom.okisemi.com>
> Following drivers are available now.
>
> [Device name} [File name]
> Common patch common_patch.tar.bz2
> CAN can.tar.bz2
> DMA dma.tar.bz2
> GbE gbe.tar.bz2
> GPIO gpio.tar.bz2
> I2C i2c.tar.bz2
> IEEE1588 ieee1588.tar.bz2
> Packet HUB pcieqos.tar.bz2
> SPI spi.tar.bz2
> UART uart.tar.bz2
> USB Device usbdev.tar.bz2
I downloaded a few of these to look at.
You need to generate them with "diff -u" - that will make them
more readable and mean they can be applied reliably to file versions that
may have changed. They also contain unrelated/debugging changes you have
made and which you probably want to remove from the submission
eg:
! kunmap(miter->page);
miter->page = NULL;
miter->addr = NULL;
--- 402,409 ----
WARN_ON(!irqs_disabled());
kunmap_atomic(miter->addr, KM_BIO_SRC_IRQ);
} else
! // kunmap(miter->page);
! kunmap(miter->page);
The code looks quite reasonable although not in the kernel style. We have
the staging directory so we can take submissions that still need clean up
so that is not an immediate concern.
I am unsure about the serial driver. The 8250 driver is already very
complicated. It might be better to make a copy of 8250, remove all the
other special cases and create a new driver for the IOH DMA serial port.
We can discuss that.
If you can create a set in diff -u format, I will go through them in more
detail and send further suggestions.
Alan
next prev parent reply other threads:[~2010-02-19 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 4:03 masa-korg
2010-02-19 14:16 ` Jonathan Corbet
2010-02-22 11:39 ` Masayuki Ohtake
2010-02-19 15:29 ` Alan Cox [this message]
2010-02-22 11:19 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219152907.75065c83@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=andrew.chih.howe.khor@intel.com \
--cc=joel.clark@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®