Re: [PATCH] Staging: dream: camera: msm_camera: fix coding style issues

[Pavel Machek <pavel@ucw.cz>]

On Thu 2010-02-11 15:47:47, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
> 
> This fixes some coding style issues like to use __func__ instead
> __FUNCTION__, "foo *bar" instead "foo* bar" and a initial comment with
> "/* */" instead "//"
> 
> Signed-off-by: Chihau Chau <chihau@gmail.com>
> ---
>  drivers/staging/dream/camera/msm_camera.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/dream/camera/msm_camera.c b/drivers/staging/dream/camera/msm_camera.c
> index 7d93877..4f808dc 100644
> --- a/drivers/staging/dream/camera/msm_camera.c
> +++ b/drivers/staging/dream/camera/msm_camera.c
> @@ -2,7 +2,7 @@
>   * Copyright (C) 2008-2009 QUALCOMM Incorporated.
>   */
>  
> -//FIXME: most allocations need not be GFP_ATOMIC
> +/* FIXME: most allocations need not be GFP_ATOMIC */
>  /* FIXME: management of mutexes */
>  /* FIXME: msm_pmem_region_lookup return values */
>  /* FIXME: way too many copy to/from user */
> @@ -361,7 +361,7 @@ static int __msm_get_frame(struct msm_sync *sync,
>  	if (!frame->buffer) {
>  		pr_err("%s: cannot get frame, invalid lookup address "
>  			"y=%x cbcr=%x offset=%d\n",
> -			__FUNCTION__,
> +			__func__,
>  			pphy->y_phy,
>  			pphy->cbcr_phy,
>  			frame->y_off);
> @@ -455,7 +455,7 @@ static int msm_disable_vfe(struct msm_sync *sync, void __user *arg)
>  	return rc;
>  }
>  
> -static struct msm_queue_cmd* __msm_control(struct msm_sync *sync,
> +static struct msm_queue_cmd *__msm_control(struct msm_sync *sync,
>  		struct msm_control_device_queue *queue,
>  		struct msm_queue_cmd *qcmd,
>  		int timeout)

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html