mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/serial2002: Fix filp_open usage
Date: Tue, 23 Feb 2010 17:56:57 -0800	[thread overview]
Message-ID: <20100224015657.GB13959@suse.de> (raw)
In-Reply-To: <87zl31b0zp.fsf@devron.myhome.or.jp>

On Tue, Feb 23, 2010 at 03:04:42AM +0900, OGAWA Hirofumi wrote:
> 
> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> 
>  drivers/staging/comedi/drivers/serial2002.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c
> --- linux-2.6/drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix	2010-02-22 23:22:27.000000000 +0900
> +++ linux-2.6-hirofumi/drivers/staging/comedi/drivers/serial2002.c	2010-02-22 23:22:27.000000000 +0900
> @@ -397,7 +397,7 @@ static void serial_2002_open(struct come
>  	char port[20];
>  
>  	sprintf(port, "/dev/ttyS%d", devpriv->port);
> -	devpriv->tty = filp_open(port, 0, O_RDWR);
> +	devpriv->tty = filp_open(port, O_RDWR, 0);

Oh wow that code is scary :)

I'll queue this up and remember to nuke the whole thing soon...

thanks,

greg k-h

      reply	other threads:[~2010-02-24  3:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 18:04 OGAWA Hirofumi
2010-02-24  1:56 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100224015657.GB13959@suse.de \
    --to=gregkh@suse.de \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®