From: Ingo Molnar <mingo@elte.hu>
To: Don Zickus <dzickus@redhat.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
gorcunov@gmail.com, aris@redhat.com
Subject: Re: [PATCH] nmi_watchdog: checkpatch.pl cleanups from earlier patches
Date: Thu, 25 Feb 2010 12:42:26 +0100 [thread overview]
Message-ID: <20100225114226.GK10212@elte.hu> (raw)
In-Reply-To: <1266880143-24943-1-git-send-email-dzickus@redhat.com>
* Don Zickus <dzickus@redhat.com> wrote:
> Mostly copy/paste whitespace damage with a couple of nitpicks by the script.
> Fix the struct definition as requested by Ingo too.
>
> Signed-off-by: Don Zickus <dzickus@redhat.com>
> --
> Ingo,
>
> I don't know how you want this patch. Like this to put on top or do you
> want me to repost everything with the cleanups inside the appropriate patch?
It's fine this way - i've put them on top - the base patches have a reasonable
amount of testing track record already, we dont want to destroy that via a
rebase.
(in the future it's useful to run checkpatch as part of your patch submission
checks. In my experience it finds real issues most of the time. Some of the
warnings have to be ignored.)
Ingo
next prev parent reply other threads:[~2010-02-25 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 23:09 Don Zickus
2010-02-22 23:24 ` Cyrill Gorcunov
2010-02-22 23:31 ` Cyrill Gorcunov
2010-02-23 15:07 ` Don Zickus
2010-02-25 11:42 ` Ingo Molnar [this message]
2010-02-25 12:07 ` [tip:perf/nmi] nmi_watchdog: Clean up various small details tip-bot for Don Zickus
2010-02-28 19:52 ` [tip:perf/nmi] nmi_watchdog: Turn it off by default tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225114226.GK10212@elte.hu \
--to=mingo@elte.hu \
--cc=aris@redhat.com \
--cc=dzickus@redhat.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®