From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "Steven J. Magnani" <steve@digidescorp.com>,
Zhang Wei <zw@zh-kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [async_tx-next PATCH 2/2] fsldma: Fix cookie issues
Date: Thu, 25 Feb 2010 11:25:39 -0800 [thread overview]
Message-ID: <20100225192539.GB32092@ovro.caltech.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.1002222123350.4120@axis700.grange>
On Mon, Feb 22, 2010 at 09:26:13PM +0100, Guennadi Liakhovetski wrote:
> On Mon, 22 Feb 2010, Steven J. Magnani wrote:
>
> > diff -uprN a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > --- a/include/linux/dmaengine.h 2010-02-22 11:18:11.000000000 -0600
> > +++ b/include/linux/dmaengine.h 2010-02-22 11:18:30.000000000 -0600
> > @@ -31,6 +31,8 @@
> > * if dma_cookie_t is >0 it's a DMA request cookie, <0 it's an error code
> > */
> > typedef s32 dma_cookie_t;
> > +#define DMA_MIN_COOKIE 1
> > +#define DMA_MAX_COOKIE 2147483647
>
> Taking into account, that dma_cookie_t is 32 bits:
>
> +#define DMA_MAX_COOKIE ((1 << 31) - 1)
>
Steven,
After you take Guennadi's comment into acount, the rest of the patch
looks good. I'm sure I've never rolled the cookie around during testing.
Ira
prev parent reply other threads:[~2010-02-25 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 17:40 Steven J. Magnani
2010-02-22 20:26 ` Guennadi Liakhovetski
2010-02-25 19:25 ` Ira W. Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225192539.GB32092@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=steve@digidescorp.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®