Re: [PATCH 1/2] serial: Add driver for the Altera JTAG UART

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

> > Use tty_termios_copy_hw() to copy the old termios hardware settings back
> > so that the caller sees it cannot set them.
> 
> Would the following be sufficient?
> 
>   if (old)
>           tty_termios_copy_hw(termios, old);

That will do the trick yes.

>   spin_lock(&port->lock);
> 
>   if (isr & ALTERA_JTAGUART_CONTROL_RE_MSK)
>           altera_jtaguart_rx_chars(pp);
>   if (isr & ALTERA_JTAGUART_CONTROL_WE_MSK)
>           altera_jtaguart_tx_chars(pp);
> 
>   spin_unlock(&port->lock);

Yes - that stops ->tty becoming NULL while your handler is running

Alan