From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751015Ab0CAF0w (ORCPT ); Mon, 1 Mar 2010 00:26:52 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:38670 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730Ab0CAF0u (ORCPT ); Mon, 1 Mar 2010 00:26:50 -0500 Date: Mon, 1 Mar 2010 10:56:43 +0530 From: Balbir Singh To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, Pavel Emelyanov , KAMEZAWA Hiroyuki , Daisuke Nishimura , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: fix typos in memcg_test.txt Message-ID: <20100301052643.GH19665@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <1267191557-23444-1-git-send-email-kirill@shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1267191557-23444-1-git-send-email-kirill@shutemov.name> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kirill A. Shutemov [2010-02-26 15:39:16]: > Signed-off-by: Kirill A. Shutemov > --- > Documentation/cgroups/memcg_test.txt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt > index 4d32e0e..f7f68b2 100644 > --- a/Documentation/cgroups/memcg_test.txt > +++ b/Documentation/cgroups/memcg_test.txt > @@ -337,7 +337,7 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y. > race and lock dependency with other cgroup subsystems. > > example) > - # mount -t cgroup none /cgroup -t cpuset,memory,cpu,devices > + # mount -t cgroup none /cgroup -o cpuset,memory,cpu,devices > > and do task move, mkdir, rmdir etc...under this. > > @@ -348,7 +348,7 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y. > > For example, test like following is good. > (Shell-A) > - # mount -t cgroup none /cgroup -t memory > + # mount -t cgroup none /cgroup -o memory > # mkdir /cgroup/test > # echo 40M > /cgroup/test/memory.limit_in_bytes > # echo 0 > /cgroup/test/tasks Looks good, Reviewed-by: Balbir Singh -- Three Cheers, Balbir