From: Jan Kara <jack@suse.cz>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] udf: use ext2_find_next_bit
Date: Mon, 1 Mar 2010 11:52:08 +0100 [thread overview]
Message-ID: <20100301105208.GB3271@quack.suse.cz> (raw)
In-Reply-To: <961aa3351002241738r7bbdc811p1fe80aabc336ae85@mail.gmail.com>
On Thu 25-02-10 10:38:25, Akinobu Mita wrote:
> 2010/2/25 Jan Kara <jack@suse.cz>:
> > On Tue 23-02-10 23:11:13, Akinobu Mita wrote:
> >> Use ext2_find_next_bit (generic_find_next_le_bit) to find the set bit
> >> in little endian bitmap region.
> >>
> >> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> >> Cc: Jan Kara <jack@suse.cz>
> > I've looked at the code and I think this is wrong. UDF uses 1 for free
> > block in the bitmap and 0 for used one. So you need to use
> > generic_find_next_le_bit...
> > Something like the patch below?
>
> According to include/asm-generic/bitops/ext2-non-atomic.h,
> generic_find_next_le_bit() == ext2_find_next_bit().
Ah, I'm really sorry. I've originally misread the header and thought that
ext2_find_next_bit == generic_find_next_le_zero_bit. So my patch does
exactly the same thing as yours. I've now merged your patch so that you get
proper credit.
> BTW, I realized that udf_find_first_one_bit() macro is not used.
> So you can remove it in this patch.
Yes, I've removed it now.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2010-03-01 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 14:11 Akinobu Mita
2010-02-24 16:21 ` Jan Kara
2010-02-25 1:38 ` Akinobu Mita
2010-02-25 8:50 ` Geert Uytterhoeven
2010-02-25 14:29 ` Akinobu Mita
2010-02-28 10:04 ` Geert Uytterhoeven
2010-02-28 14:07 ` Geert Uytterhoeven
2010-03-01 10:54 ` Jan Kara
2010-03-01 10:52 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301105208.GB3271@quack.suse.cz \
--to=jack@suse.cz \
--cc=akinobu.mita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®