From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753931Ab0CCGKH (ORCPT ); Wed, 3 Mar 2010 01:10:07 -0500 Received: from mail-yx0-f182.google.com ([209.85.210.182]:38739 "EHLO mail-yx0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043Ab0CCGKF (ORCPT ); Wed, 3 Mar 2010 01:10:05 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Uy8USYbfDi0/PMa43b3IXjESB20UfVvQvJw76hXjJ6o8zERP+SD7zRNekyOhTkyq9k tBxqBfP6pJNSqkgmdGBTfWt1M0t2YW65MCPBugdmhzmPPTgum8LtVOdWwFHtbHgk47wI WN7GbT0+5eq4FeVu2tRRelfBMDo93oI5qzBS0= Date: Tue, 2 Mar 2010 22:09:56 -0800 From: Dmitry Torokhov To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Randy Dunlap , Lennart Poettering , "Lee, Chun-Yi" , Andrew Morton Subject: Re: [PATCH 61/62] msi-laptop: depends on RFKILL Message-ID: <20100303060955.GA2244@core.coreip.homeip.net> References: <20100302230933.GA32287@kroah.com> <1267572541-410-61-git-send-email-gregkh@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1267572541-410-61-git-send-email-gregkh@suse.de> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 02, 2010 at 03:29:00PM -0800, Greg Kroah-Hartman wrote: > From: Randy Dunlap > > msi-laptop uses rfkill*() interfaces so it should depend on RFKILL. > > msi-laptop.c:(.text+0x1fcd1b): undefined reference to `rfkill_alloc' > msi-laptop.c:(.text+0x1fcd76): undefined reference to `rfkill_register' > msi-laptop.c:(.text+0x1fcdc8): undefined reference to `rfkill_destroy' > msi-laptop.c:(.text+0x1fcdd9): undefined reference to `rfkill_unregister' > > This repairs "msi-laptop: Detect 3G device exists by standard ec command", > which is in some gregkh tree. > > Signed-off-by: Randy Dunlap > Cc: Lennart Poettering > Cc: Lee, Chun-Yi > Signed-off-by: Andrew Morton > Signed-off-by: Greg Kroah-Hartman > --- > drivers/platform/x86/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 6848f21..d911de3 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -148,6 +148,7 @@ config MSI_LAPTOP > tristate "MSI Laptop Extras" > depends on ACPI > depends on BACKLIGHT_CLASS_DEVICE > + depends on RFKILL I must say I really dislike when "depends" is used with drivers like this for high-level subsystems. How would a user (advanced, I agree) know about existence of such a driver when doing make oldconfig unless he examines entirety of the pull (new rc patch, tarball, whatever)? And even if he is aware of the new driver he needs to know exact config name to see the dependencies (even if he knows how)... We all know dangers of "select" but I think it is useful when used judiciously, for entire subsystems only (like selecting serio, backlight, leds, etc) that do not have additional dependencies. Thanks. -- Dmitry