From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] Call flush_dcache_page around PIO data transfers in libata-aff.c
Date: Wed, 3 Mar 2010 09:24:43 +0100 [thread overview]
Message-ID: <20100303082443.GA11944@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <20100129160150.22571.28609.stgit@pc1117.cambridge.arm.com>
> drivers/ata/libata-sff.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
>index 741065c..3d3c854 100644
>--- a/drivers/ata/libata-sff.c
>+++ b/drivers/ata/libata-sff.c
>@@ -893,6 +896,9 @@ static void ata_pio_sector(struct ata_queued_cmd *qc)
> do_write);
> }
>
>+ if (!do_write)
>+ flush_dcache_page(page);
>+
> qc->curbytes += qc->sect_size;
> qc->cursg_ofs += qc->sect_size;
That part got merged and it leads to a BUG if CONFIG_DEBUG_VM is
enabled. My mips box and arm use page_mapping() in flush_dcache_page()
which has VM_BUG_ON(PageSlab(page)) in it.
Any comments on that?
Sebastian
next prev parent reply other threads:[~2010-03-03 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 16:10 Catalin Marinas
2010-03-03 8:24 ` Sebastian Andrzej Siewior [this message]
2010-03-03 11:18 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303082443.GA11944@Chamillionaire.breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®