From: Oliver Neukum <oliver@neukum.org>
To: Johan Hovold <jhovold@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg KH <greg@kroah.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Peter Feuerer <peter@piie.net>
Subject: Re: [PATCH] USB: pl2303: switch to generic write implementation
Date: Wed, 3 Mar 2010 16:08:20 +0100 [thread overview]
Message-ID: <201003031608.20277.oliver@neukum.org> (raw)
In-Reply-To: <1267628493-30080-1-git-send-email-jhovold@gmail.com>
Am Mittwoch, 3. März 2010 16:01:33 schrieb Johan Hovold:
> @@ -941,10 +665,8 @@ static void pl2303_release(struct usb_serial *serial)
>
> for (i = 0; i < serial->num_ports; ++i) {
> priv = usb_get_serial_port_data(serial->port[i]);
> - if (priv) {
> - pl2303_buf_free(priv->buf);
> + if (priv)
> kfree(priv);
> - }
> }
> }
No need to test for NULL.
Regards
Oliver
next prev parent reply other threads:[~2010-03-03 15:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 18:07 [BUG] usb-serial / pl2302 corrupted receive Peter Feuerer
2010-03-02 23:53 ` Greg KH
2010-03-03 10:47 ` peter
2010-03-03 14:17 ` Johan Hovold
2010-03-03 18:31 ` Andreas Kemnade
2010-03-03 12:14 ` Alan Cox
2010-03-03 14:50 ` Johan Hovold
2010-03-03 15:01 ` [PATCH] USB: pl2303: switch to generic write implementation Johan Hovold
2010-03-03 15:08 ` Oliver Neukum [this message]
2010-03-04 11:12 ` [PATCH v2] " Johan Hovold
2010-03-15 23:20 ` Greg KH
2010-03-17 9:16 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003031608.20277.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter@piie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®