From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753356Ab0CFOoZ (ORCPT ); Sat, 6 Mar 2010 09:44:25 -0500 Received: from mail.in-ulm.de ([217.10.8.10]:59004 "HELO mail.in-ulm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753185Ab0CFOoY (ORCPT ); Sat, 6 Mar 2010 09:44:24 -0500 Date: Sat, 6 Mar 2010 15:44:22 +0100 From: Christian Ehrhardt To: Johannes Weiner Cc: Rik van Riel , Christian Ehrhardt , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] rmap: Fix Bugzilla Bug #5493 Message-ID: <20100306144422.GI17078@lisa.in-ulm.de> References: <20100305093834.GG17078@lisa.in-ulm.de> <4B9110ED.5000703@redhat.com> <20100306010212.GH17078@lisa.in-ulm.de> <20100306020048.GA16967@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100306020048.GA16967@cmpxchg.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Mar 06, 2010 at 03:00:48AM +0100, Johannes Weiner wrote: > What's with expand_stack()? This changes the radix index or the heap > index, depending on the direction in which the stack grows, but it > does not adjust the tree and so its order is violated. Did you make > sure that this is fine? Ooops! Thanks for the hint. Not only expand stack but also vma_adjust (aka vma_merge) need to update the tree, I guess. However, it is somewhat odd that this did not trigger anything in my tests. I guess I have to come up with a testcase that properly checks this case. regards Christian