From: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>
To: petkovbb@googlemail.com
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs, binfmt_aout: Fix pointer warnings
Date: Tue, 09 Mar 2010 10:11:21 +0900 (JST) [thread overview]
Message-ID: <20100309.101121.193684481.d.hatayama@jp.fujitsu.com> (raw)
In-Reply-To: <20100308154601.GA30454@a1.tnic>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=utf-8, Size: 3340 bytes --]
Thanks for your report.
From: Borislav Petkov <petkovbb@googlemail.com>
Subject: [PATCH] fs, binfmt_aout: Fix pointer warnings
Date: Mon, 8 Mar 2010 16:46:01 +0100
> Hi,
>
> I'm getting the warnings in the commit message below with current git. Maybe fix
> them like this:
>
> --
> From: Borislav Petkov <petkovbb@gmail.com>
> Date: Mon, 8 Mar 2010 16:37:42 +0100
> Subject: [PATCH] fs, binfmt_aout: Fix pointer warnings
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> I get
>
> fs/binfmt_aout.c: In function âaout_core_dumpâ:
> fs/binfmt_aout.c:125: warning: passing argument 2 of âdump_writeâ makes pointer from integer without a cast
> include/linux/coredump.h:12: note: expected âconst void *â but argument is of type âlong unsigned intâ
> fs/binfmt_aout.c:132: warning: passing argument 2 of âdump_writeâ makes pointer from integer without a cast
> include/linux/coredump.h:12: note: expected âconst void *â but argument is of type âlong unsigned intâ
>
> due to dump_write() expecting a user void *. Fold casts into the
> START_DATA/START_STACK macros and shut up the warnings.
>
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
> ---
> fs/binfmt_aout.c | 14 ++++++++------
> 1 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> index 15d80bb..9b6aef0 100644
> --- a/fs/binfmt_aout.c
> +++ b/fs/binfmt_aout.c
> @@ -75,14 +75,16 @@ static int aout_core_dump(struct coredump_params *cprm)
> struct file *file = cprm->file;
> mm_segment_t fs;
> int has_dumped = 0;
> - unsigned long dump_start, dump_size;
> + void __user *dump_start;
> + int dump_size;
> struct user dump;
> #ifdef __alpha__
> -# define START_DATA(u) (u.start_data)
> +# define START_DATA(u) ((void __user *)u.start_data)
> #else
> -# define START_DATA(u) ((u.u_tsize << PAGE_SHIFT) + u.start_code)
> +# define START_DATA(u) ((void __user *)((u.u_tsize << PAGE_SHIFT) + \
> + u.start_code))
> #endif
> -# define START_STACK(u) (u.start_stack)
> +# define START_STACK(u) ((void __user *)u.start_stack)
>
> fs = get_fs();
> set_fs(KERNEL_DS);
> @@ -104,9 +106,9 @@ static int aout_core_dump(struct coredump_params *cprm)
>
> /* make sure we actually have a data and stack area to dump */
> set_fs(USER_DS);
> - if (!access_ok(VERIFY_READ, (void __user *)START_DATA(dump), dump.u_dsize << PAGE_SHIFT))
> + if (!access_ok(VERIFY_READ, START_DATA(dump), dump.u_dsize << PAGE_SHIFT))
> dump.u_dsize = 0;
> - if (!access_ok(VERIFY_READ, (void __user *)START_STACK(dump), dump.u_ssize << PAGE_SHIFT))
> + if (!access_ok(VERIFY_READ, START_STACK(dump), dump.u_ssize << PAGE_SHIFT))
> dump.u_ssize = 0;
Your fixing looks reasonable to me. I understand your patch set as
follows.
- The START_DATA() and START_STACK() macro calls are all passed to
the arguments of type (void *), meaning that they need casts in
the appropreate positions.
- Moreover, they are more natural to be used directly as (void *)
than to be casted outside the macro.
Thanks.
>
> set_fs(KERNEL_DS);
> --
> 1.6.6.1
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
prev parent reply other threads:[~2010-03-09 1:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 15:46 Borislav Petkov
2010-03-09 1:11 ` Daisuke HATAYAMA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309.101121.193684481.d.hatayama@jp.fujitsu.com \
--to=d.hatayama@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®