Re: [PATCH] freezer: only show the state of tasks refusing to freeze

[Pavel Machek <pavel@ucw.cz>]

> show_state will dump all tasks state, so if freezer failed to freeze
> any task, kernel will dump all tasks state and flood the dmesg log.
> This patch makes freezer only show state of tasks refusing to freeze.
> 
> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
> Cc: Pavel Machek <pavel@ucw.cz>

ACK.

> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 5ade1bd..a0480cd 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -88,12 +88,11 @@ static int try_to_freeze_tasks(bool sig_only)
>  		printk(KERN_ERR "Freezing of tasks failed after %d.%02d seconds "
>  				"(%d tasks refusing to freeze):\n",
>  				elapsed_csecs / 100, elapsed_csecs % 100, todo);
> -		show_state();
>  		read_lock(&tasklist_lock);
>  		do_each_thread(g, p) {
>  			task_lock(p);
>  			if (freezing(p) && !freezer_should_skip(p))
> -				printk(KERN_ERR " %s\n", p->comm);
> +				sched_show_task(p);
>  			cancel_freezing(p);
>  			task_unlock(p);
>  		} while_each_thread(g, p);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html