From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932511Ab0CLKSL (ORCPT ); Fri, 12 Mar 2010 05:18:11 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:40782 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932238Ab0CLKSJ (ORCPT ); Fri, 12 Mar 2010 05:18:09 -0500 Date: Fri, 12 Mar 2010 10:18:00 +0000 From: Russell King - ARM Linux To: Benjamin Valentin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dinuxbg@gmail.com Subject: Re: [PATCH 1/2] Add support for Olimex SAM9-L9261 SBC Message-ID: <20100312101800.GB29306@n2100.arm.linux.org.uk> References: <20100312105817.4392b594@rechenknecht2k7> <20100312110032.2e57fdce@rechenknecht2k7> <20100312100454.GA29306@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100312100454.GA29306@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2010 at 10:04:54AM +0000, Russell King - ARM Linux wrote: > On Fri, Mar 12, 2010 at 11:00:32AM +0100, Benjamin Valentin wrote: > > diff -urpN -x CVS linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig > > --- linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig 1970-01-01 02:00:00.000000000 +0200 > > +++ linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig 2008-10-28 06:08:46.000000000 +0200 > > @@ -0,0 +1,1606 @@ > > Please think about your reviewers when you send patches - do you think > it's reasonable to expect reviewers to scroll through 1600 lines before > they get to something interesting to read? > > Always split defconfig patches into a separate patch. Oh, and please include a diffstat and signed-off-by lines as per Documentation/SubmittingPatches.