From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935360Ab0CMBRt (ORCPT ); Fri, 12 Mar 2010 20:17:49 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57499 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936358Ab0CMBRl (ORCPT ); Fri, 12 Mar 2010 20:17:41 -0500 Date: Fri, 12 Mar 2010 17:14:23 -0500 From: Andrew Morton To: Thomas Gleixner Cc: LKML , Ingo Molnar , u.kleine-koenig@pengutronix.de, a.p.zijlstra@chello.nl, andrea.gallo@stericsson.com, dbrownell@users.sourceforge.net, eric.y.miao@gmail.com, hugh.dickins@tiscali.co.uk, jamie@shareable.org, John Stultz , linux@bohmer.net, nico@marvell.com, Rusty Russell , Greg KH , David Miller Subject: Re: [patch 2/3] genirq: warn about IRQF_SHARED|IRQF_DISABLED at the right place Message-Id: <20100312171423.b7e7a838.akpm@linux-foundation.org> In-Reply-To: References: <201003112208.o2BM8wJU013575@imap1.linux-foundation.org> <20100312155015.090ba541.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.3; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Mar 2010 01:59:50 +0100 (CET) Thomas Gleixner wrote: > > I'm simply refusing to apply patches which just shuffle code around to > warn about obscure use cases instead of tackling the real problem of > long running irq handlers which prevent us to get rid of IRQF_DISABLED > and just run all interrupt handlers with irqs disabled. I'm having trouble agreeing with that aim, really. We can tweak and tune until we're blue in the face, but the system's IRQ latency will always be worse if handlers always run with interrupts disabled. Plus this approach introduces dependencies between unrelated drivers (and between _each_ driver and the overall system) which simply don't exist if those drivers are being nicer to the rest of the system.