From: Simon Horman <horms@verge.net.au>
To: Steven Harms <sjharms@gmail.com>
Cc: gregkh@suse.de, bobby.prani@gmail.com, sharms@ubuntu.com,
dcb314@hotmail.com, a.beregalov@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: otus: Remove mix of tabs and spaces with just tabs in ioctl.c
Date: Mon, 15 Mar 2010 08:20:55 +1100 [thread overview]
Message-ID: <20100314212055.GC5893@verge.net.au> (raw)
In-Reply-To: <1268582160-8713-1-git-send-email-sharms@ubuntu.com>
On Sun, Mar 14, 2010 at 11:56:00AM -0400, Steven Harms wrote:
> Previously defines had a mix of both tabs and spaces, causing an error in the checkpatch tool. These tabs and spaces have been consolidated to only tabs.
> Signed-off-by: Steven Harms <sharms@ubuntu.com>
Looks good to me.
Acked-by: Simon Horman <horms@verge.net.au>
> ---
> drivers/staging/otus/ioctl.c | 30 +++++++++++++++---------------
> 1 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/otus/ioctl.c b/drivers/staging/otus/ioctl.c
> index 8c47b1a..963d807 100644
> --- a/drivers/staging/otus/ioctl.c
> +++ b/drivers/staging/otus/ioctl.c
> @@ -29,34 +29,34 @@
>
> #include "usbdrv.h"
>
> -#define ZD_IOCTL_WPA (SIOCDEVPRIVATE + 1)
> -#define ZD_IOCTL_PARAM (SIOCDEVPRIVATE + 2)
> -#define ZD_IOCTL_GETWPAIE (SIOCDEVPRIVATE + 3)
> +#define ZD_IOCTL_WPA (SIOCDEVPRIVATE + 1)
> +#define ZD_IOCTL_PARAM (SIOCDEVPRIVATE + 2)
> +#define ZD_IOCTL_GETWPAIE (SIOCDEVPRIVATE + 3)
> #ifdef ZM_ENABLE_CENC
> -#define ZM_IOCTL_CENC (SIOCDEVPRIVATE + 4)
> +#define ZM_IOCTL_CENC (SIOCDEVPRIVATE + 4)
> #endif /* ZM_ENABLE_CENC */
> -#define ZD_PARAM_ROAMING 0x0001
> -#define ZD_PARAM_PRIVACY 0x0002
> -#define ZD_PARAM_WPA 0x0003
> +#define ZD_PARAM_ROAMING 0x0001
> +#define ZD_PARAM_PRIVACY 0x0002
> +#define ZD_PARAM_WPA 0x0003
> #define ZD_PARAM_COUNTERMEASURES 0x0004
> #define ZD_PARAM_DROPUNENCRYPTED 0x0005
> -#define ZD_PARAM_AUTH_ALGS 0x0006
> -#define ZD_PARAM_WPS_FILTER 0x0007
> +#define ZD_PARAM_AUTH_ALGS 0x0006
> +#define ZD_PARAM_WPS_FILTER 0x0007
>
> #ifdef ZM_ENABLE_CENC
> #define P80211_PACKET_CENCFLAG 0x0001
> #endif /* ZM_ENABLE_CENC */
> -#define P80211_PACKET_SETKEY 0x0003
> +#define P80211_PACKET_SETKEY 0x0003
>
> #define ZD_CMD_SET_ENCRYPT_KEY 0x0001
> -#define ZD_CMD_SET_MLME 0x0002
> -#define ZD_CMD_SCAN_REQ 0x0003
> +#define ZD_CMD_SET_MLME 0x0002
> +#define ZD_CMD_SCAN_REQ 0x0003
> #define ZD_CMD_SET_GENERIC_ELEMENT 0x0004
> -#define ZD_CMD_GET_TSC 0x0005
> +#define ZD_CMD_GET_TSC 0x0005
>
> #define ZD_CRYPT_ALG_NAME_LEN 16
> -#define ZD_MAX_KEY_SIZE 32
> -#define ZD_MAX_GENERIC_SIZE 64
> +#define ZD_MAX_KEY_SIZE 32
> +#define ZD_MAX_GENERIC_SIZE 64
>
> #include <net/iw_handler.h>
>
> --
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2010-03-14 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 15:56 Steven Harms
2010-03-14 21:20 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100314212055.GC5893@verge.net.au \
--to=horms@verge.net.au \
--cc=a.beregalov@gmail.com \
--cc=bobby.prani@gmail.com \
--cc=dcb314@hotmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sharms@ubuntu.com \
--cc=sjharms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®