From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937078Ab0COXBP (ORCPT ); Mon, 15 Mar 2010 19:01:15 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58516 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932386Ab0COXBL (ORCPT ); Mon, 15 Mar 2010 19:01:11 -0400 Date: Mon, 15 Mar 2010 16:01:33 -0700 (PDT) Message-Id: <20100315.160133.67908104.davem@davemloft.net> To: keil@b1-systems.de Cc: torvalds@linux-foundation.org, lars.ellenberg@linbit.com, netdev@vger.kernel.org, andreas@eversberg.eu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe From: David Miller In-Reply-To: <1268668176.12629@pingi> References: <1268668176.12629@pingi> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Karsten Keil Date: Mon, 15 Mar 2010 14:18:41 +0100 > A few subdevice IDs seem to have been dropped when hfc_multi was > included upstream, just compare the list at > http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=75&view=annotate#l175 > with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c > > Added PCIe 2 Port card and LED settings (same as PCI) /KKe > > Signed-off-by: Lars Ellenberg > Signed-off-by: Karsten Keil We don't add new defines to linux/pci_ids.h, it is deprecated. Simply add the device ID constants to the table. The only exception is the case where a device ID is used in more than one driver, but even that scenerio is heavily discouraged.