From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S936602Ab0COTjf (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Mar 2010 15:39:35 -0400
Received: from cantor.suse.de ([195.135.220.2]:59341 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932117Ab0COTje (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Mar 2010 15:39:34 -0400
Date: Mon, 15 Mar 2010 12:35:44 -0700
From: Greg KH <gregkh@suse.de>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Lars Lindley <lindley@coyote.org>, Dan Carpenter <error27@gmail.com>,
       greg@kroah.com, pavel@ucw.cz, diegoliz@gmail.com,
       devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
       stefanr@s5r6.in-berlin.de
Subject: Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.
Message-ID: <20100315193544.GB15146@suse.de>
References: <1268670973-6223-1-git-send-email-lindley@coyote.org>
 <20100315165052.GA2661@bicker>
 <4B9E65DE.7060409@cs.helsinki.fi>
 <4B9E6CA2.10602@coyote.org>
 <4B9E7903.30402@cs.helsinki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B9E7903.30402@cs.helsinki.fi>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 15, 2010 at 08:14:27PM +0200, Pekka Enberg wrote:
> Lars Lindley wrote:
> >On 2010-03-15 17:52, Pekka Enberg wrote:
> >>Dan Carpenter wrote:
> >>>On Mon, Mar 15, 2010 at 05:36:13PM +0100, Lars Lindley wrote:
> >>>>I fixed most of the problems found by checkpatch.pl.
> >>>>Some long lines are left and some KERN_..
> >>>>This is a new revised patch against master with changes
> >>>>after comments from Stefan Richter and Dan Carpenter.
> >>>>Forget the old one.
> >>>>
> >>>>Signed-off-by: Lars Lindley <lindley@coyote.org>
> >>>>Acked-by: Pavel Machek <pavel@ucw.cz>
> >>>Acked-by: Dan Carpenter <error27@gmail.com>
> >>It's pretty difficult to say if anything changed based on the diff so
> >>would you mind posting before and after output of 'size mds.o', please?
> >>
> >Hi Pekka.
> >
> >Before:
> >lali@lazer2 ~/linux3/linux-2.6 $ size drivers/staging/winbond/mds.o
> >   text	   data	    bss	    dec	    hex	filename
> >   2804	      0	      0	   2804	    af4	drivers/staging/winbond/mds.o
> >
> >After:
> >lali@lazer2 ~/linux2/linux-2.6 $ size drivers/staging/winbond/mds.o
> >   text	   data	    bss	    dec	    hex	filename
> >   2804	      0	      0	   2804	    af4	drivers/staging/winbond/mds.o
> >
> >diff:
> >lali@lazer2 ~/linux2/linux-2.6 $ diff ../../linux3/linux-2.6/drivers/staging/winbond/mds.o drivers/staging/winbond/mds.o
> >lali@lazer2 ~/linux2/linux-2.6 $
> >
> >linux3 is a clean tree and linux2 the one i'm working on..
> 
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> 
> Greg, can you pick up my typedef cleanups and this patch to -staging?

Yes, will do.

thanks,

greg k-h