From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S966242Ab0CPNyJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Mar 2010 09:54:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49747 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S966216Ab0CPNyH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Mar 2010 09:54:07 -0400
Date: Tue, 16 Mar 2010 09:53:46 -0400
From: Vivek Goyal <vgoyal@redhat.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
       Gui Jianfeng <GuiJianfeng@cn.fujitsu.com>,
       Ben Blum <bblum@andrew.cmu.edu>, LKML <linux-kernel@vger.kernel.org>,
       "containers@lists.osdl.org" <containers@lists.osdl.org>
Subject: Re: [PATCH] block: make CONFIG_BLK_CGROUP visible
Message-ID: <20100316135346.GB9144@redhat.com>
References: <4B9DA6F5.3070606@cn.fujitsu.com> <20100315132149.GA21127@redhat.com> <4B9EE0A9.5010901@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B9EE0A9.5010901@cn.fujitsu.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 16, 2010 at 09:36:41AM +0800, Li Zefan wrote:
> >>  	---help---
> >>  	Generic block IO controller cgroup interface. This is the common
> >> @@ -91,7 +92,7 @@ config BLK_CGROUP
> >>  	to such task groups.
> >>  
> >>  config DEBUG_BLK_CGROUP
> >> -	bool
> >> +	bool "Block cgroup debugging help"
> > 
> > 
> > Why are you making DEBUG_BLK_CGROUP this as a user visible/configurable
> > option? This is already controlled by DEBUG_CFQ_IOSCHED. If you don't want
> > the DEBUG overhead, just set DEBUG_CFQ_IOSCHED=n and DEBUG_BLK_CGROUP will
> > not be selected? Making it user visible does not seem to be buying us
> > anything?
> > 
> 
> Sounds reasonable. A minor question, since DEBUG_BLK_CGROUP is not
> visible, the help message for this config is not visible too, so we
> still keep it?

Right now the message is only for developer if somebody opens the Kconfig
file. I think it does not harm if somebody wants to understand what this
config option is doing. But if you think that it should not be there, I have
no strong opinion about it.

Thanks
Vivek