From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758046Ab0CPUsP (ORCPT ); Tue, 16 Mar 2010 16:48:15 -0400 Received: from mail96.messagelabs.com ([216.82.254.19]:27888 "EHLO mail96.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648Ab0CPUsN convert rfc822-to-8bit (ORCPT ); Tue, 16 Mar 2010 16:48:13 -0400 X-VirusChecked: Checked X-Env-Sender: jayamohank@serverengines.com X-Msg-Ref: server-7.tower-96.messagelabs.com!1268772491!46067213!1 X-StarScan-Version: 6.2.4; banners=-,-,- X-Originating-IP: [68.165.1.68] To: "Jiri Slaby" , James.Bottomley@suse.de Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com From: "Jayamohan Kalickal" Organization: Serverengines LLC Subject: Re: [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance Message-ID: <20100316204810.47e381d0@mailhost.serverengines.com> Date: Tue, 16 Mar 2010 13:48:10 -0700 X-User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.5) Gecko/2008120908 Red Hat/3.0.5-1.el5_2 Firefox/3.0.5 GTB6 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-By: Jayamohan Kallickal -- _____ From: Jiri Slaby [mailto:jslaby@suse.cz] To: James.Bottomley@suse.de Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com, Jayamohan Kallickal [mailto:jayamohank@serverengines.com] Sent: Tue, 16 Mar 2010 08:23:57 -0700 Subject: [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance Stanse found that one error path in mgmt_invalidate_icds omits to unlock ctrl->mbox_lock. Fix that. Added in 756d29c8c7ed8887ed7d752371ce2f (Enable async mode for mcc rings) where the spinlock was moved. Signed-off-by: Jiri Slaby Cc: Jayamohan Kallickal Cc: James Bottomley --- drivers/scsi/be2iscsi/be_mgmt.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index 72617b6..e641922 100644 --- a/drivers/scsi/be2iscsi/be_mgmt.c +++ b/drivers/scsi/be2iscsi/be_mgmt.c @@ -169,6 +169,7 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba, SE_DEBUG(DBG_LVL_1, "Failed to allocate memory for" "mgmt_invalidate_icds \n"); + spin_unlock(&ctrl->mbox_lock); return -1; } nonemb_cmd.size = sizeof(struct invalidate_commands_params_in); -- 1.7.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ___________________________________________________________________________________ This message, together with any attachment(s), contains confidential and proprietary information of ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized review, printing, retention, copying, disclosure or distribution is strictly prohibited. If you are not the intended recipient of this message, please immediately advise the sender by reply email message and delete all copies of this message and any attachment(s). Thank you.