Re: [PATCH -tip 00/10] perf-probe updates - data-structure support, etc.

[Ingo Molnar <mingo@elte.hu>]

* Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Hi Ingo,
> 
> Here are several updates of perf-probe.
> This updates includes data structure accessing support
> --list option enhancement and --dry-run option support.
> 
> - --dry-run allows users to run perf-probe just for checking
>   that the command works correctly.
> 
> - --list option enhancement allows user to check where the
>   probes are put on (with filename/line number).
> 
> - data structure accessing support allows user to trace
>   the contents of local variables/function parameters.

Very nice! I think tracing a data structure value at a given point in the 
source will be a rather popular feature.

> Long-term TODOs (future features):
>   - Enhance probe-finder to decode call frame instructions.
>   - Support tracing static variables (non global)
>   - Support variable basic types from debuginfo (e.g. char, int, ...)
>   - Support array element (var[N])
>   - Support string/dynamic arrays (*var, var[N..M])
>   - Support the type of return value
>   - Support force type-casting ((type)var)
>   - Support sys_perf_counter_open (for non-root users)
>   - Support dynamic array-indexing (var[var2])
> 
> Miscs:
>   - Better support for probes on modules
>   - More debugger like enhancements(%next, --disasm, etc.)

Sounds good :-)

> Masami Hiramatsu (10):
>       perf probe: Accessing members in data structures
>       perf probe: List probes with line number and file name
>       perf probe: Introduce kprobe_trace_event and perf_probe_event
>       perf probe: Add --dry-run option
>       perf probe: Introduce die_find_child() function
>       perf probe: Rename some die_get_* functions
>       perf probe: Rename session to param
>       perf probe: Move add-probe routine under util/
>       perf probe: Use wrapper functions
>       perf tools: Introduce xzalloc() for detecting out of memory
> 
> 
>  tools/perf/Documentation/perf-probe.txt |    5 
>  tools/perf/builtin-probe.c              |  191 +------
>  tools/perf/util/probe-event.c           |  830 +++++++++++++++++++++++--------
>  tools/perf/util/probe-event.h           |  123 ++++-
>  tools/perf/util/probe-finder.c          |  459 ++++++++++++-----
>  tools/perf/util/probe-finder.h          |   60 +-
>  tools/perf/util/util.h                  |    7 
>  7 files changed, 1115 insertions(+), 560 deletions(-)

Applied, thanks!

	Ingo